appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

chore: copy old ads components and move them to packages

Open KelvinOm opened this issue 1 year ago • 29 comments

Description

Move old ADS components used in widgets to a local package. Fix prettier, linter and type check errors

List of widgets that may be affected:

  1. BaseInputWidget
  2. ButtonWidget
  3. CurrencyInputWidget
  4. InputWidget
  5. PhoneInputWidget
  6. DropdownWidget
  7. ListWidget
  8. ListWidgetV2
  9. MultiSelectTreeWidget
  10. MultiSelectWidget
  11. MultiSelectWidgetV2
  12. RateWidget
  13. SelectWidget
  14. SingleSelectTreeWidget
  15. TableWidget
  16. TableWidgetV2
  17. TabsWidget
  18. TextWidget

PR fixes following issue(s)

Fixes #22988

Type of change

  • Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. Delete anything that is not relevant

  • [x] Manual
  • [x] Jest
  • [x] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

KelvinOm avatar May 09 '23 13:05 KelvinOm

/ok-to-test sha=5564aed

KelvinOm avatar May 09 '23 14:05 KelvinOm

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4927123369. Workflow: Appsmith External Integration Test Workflow. Commit: 5564aed. PR: 23142. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23142&runId=4927123369_1

github-actions[bot] avatar May 09 '23 14:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4927123369. Commit: 5564aed. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
  2. cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/False_Spec.ts
  3. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 09 '23 16:05 github-actions[bot]

/ok-to-test sha=5d4835e

KelvinOm avatar May 09 '23 17:05 KelvinOm

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4928719908. Workflow: Appsmith External Integration Test Workflow. Commit: 5d4835e. PR: 23142. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23142&runId=4928719908_1

github-actions[bot] avatar May 09 '23 17:05 github-actions[bot]

/build-wds-preview

KelvinOm avatar May 09 '23 17:05 KelvinOm

Deploy-Preview-URL: https://widget-design-system-6vn76q3oz-get-appsmith.vercel.app

github-actions[bot] avatar May 09 '23 17:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4927123369. Commit: 5564aed. All cypress tests have passed 🎉

github-actions[bot] avatar May 09 '23 17:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4928719908. Commit: 5d4835e. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/uiToCode/uiToCode_spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 09 '23 19:05 github-actions[bot]

/ok-to-test sha=382ec16

KelvinOm avatar May 10 '23 07:05 KelvinOm

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4934389128. Workflow: Appsmith External Integration Test Workflow. Commit: 382ec16. PR: 23142. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23142&runId=4934389128_1

github-actions[bot] avatar May 10 '23 07:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4934389128. Commit: 382ec16. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/AppNavigation/TopStacked_spec.js
  2. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_CurlPOSTImport_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 10 '23 09:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4934389128. Commit: 382ec16. All cypress tests have passed 🎉

github-actions[bot] avatar May 10 '23 10:05 github-actions[bot]

/ok-to-test sha= 2349c19

KelvinOm avatar May 10 '23 12:05 KelvinOm

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4936827872. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23142. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23142&runId=4936827872_1

github-actions[bot] avatar May 10 '23 12:05 github-actions[bot]

/ok-to-test sha=2349c19

KelvinOm avatar May 10 '23 13:05 KelvinOm

/ok-to-test sha=2349c19

KelvinOm avatar May 10 '23 13:05 KelvinOm

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4937697005. Workflow: Appsmith External Integration Test Workflow. Commit: 2349c19. PR: 23142. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23142&runId=4937697005_1

github-actions[bot] avatar May 10 '23 13:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4936827872. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_CurlPOSTImport_spec.js
  2. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 10 '23 13:05 github-actions[bot]

/ok-to-test sha=2349c19

KelvinOm avatar May 10 '23 16:05 KelvinOm

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4937697005. Commit: 2349c19. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 10 '23 16:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4936827872. Commit: ``. The following are new failures, please fix them before merging the PR:

    To know the list of identified flaky tests - Refer here

    github-actions[bot] avatar May 10 '23 16:05 github-actions[bot]

    /ok-to-test sha=6ec3f83

    KelvinOm avatar May 11 '23 09:05 KelvinOm

    Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4946113402. Workflow: Appsmith External Integration Test Workflow. Commit: 6ec3f83. PR: 23142. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23142&runId=4946113402_1

    github-actions[bot] avatar May 11 '23 09:05 github-actions[bot]

    Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4946113402. Commit: 6ec3f83. The following are new failures, please fix them before merging the PR:

    1. cypress/integration/Regression_TestSuite/Application/EchoApiCMS_spec.js
    2. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
    3. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
    4. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Canvas_Context_Property_Pane_spec.js
    5. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
    6. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
    To know the list of identified flaky tests - Refer here

    github-actions[bot] avatar May 11 '23 10:05 github-actions[bot]

    /build-deploy-preview

    Aishwarya-U-R avatar May 11 '23 11:05 Aishwarya-U-R

    Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4947180632. Workflow: On demand build Docker image and deploy preview. skip-tests: . env: . PR: 23142. recreate: .

    github-actions[bot] avatar May 11 '23 11:05 github-actions[bot]

    Deploy-Preview-URL: https://ce-23142.dp.appsmith.com

    github-actions[bot] avatar May 11 '23 11:05 github-actions[bot]

    Ran a regression on all the widgets mentioned and found no issues specific to this PR. LGTM.

    cc: @shadabbuchh

    laveena-en avatar May 13 '23 17:05 laveena-en