appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: show evaluated value for action selector fields

Open ravikp7 opened this issue 1 year ago • 7 comments

Description

The evaluated values for text fields in action selector were not shown. This PR fixes the issue.

PR fixes following issue(s)

Fixes #12736

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

  • [x] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

ravikp7 avatar May 08 '23 20:05 ravikp7

/ok-to-test sha=410f54a

ravikp7 avatar May 08 '23 20:05 ravikp7

/build-deploy-preview env=release

ravikp7 avatar May 08 '23 20:05 ravikp7

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4919367342. Workflow: Appsmith External Integration Test Workflow. Commit: 410f54a. PR: 23099. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23099&runId=4919367342_1

github-actions[bot] avatar May 08 '23 20:05 github-actions[bot]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4919368574. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23099. recreate: .

github-actions[bot] avatar May 08 '23 20:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-1a2qauwh6-get-appsmith.vercel.app

github-actions[bot] avatar May 08 '23 20:05 github-actions[bot]

/ok-to-test sha=f0b99dd

ravikp7 avatar May 12 '23 03:05 ravikp7

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4954951836. Workflow: Appsmith External Integration Test Workflow. Commit: f0b99dd. PR: 23099. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23099&runId=4954951836_1

github-actions[bot] avatar May 12 '23 03:05 github-actions[bot]

lgtm cc: @ravikp7

ramsaptami avatar May 15 '23 11:05 ramsaptami

/ok-to-test sha=300a904

ravikp7 avatar May 16 '23 06:05 ravikp7

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4988423177. Workflow: Appsmith External Integration Test Workflow. Commit: 300a904. PR: 23099. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23099&runId=4988423177_1

github-actions[bot] avatar May 16 '23 06:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4988423177. Commit: 300a904. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/Application/EchoApiCMS_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 16 '23 11:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4988423177. Commit: 300a904. All cypress tests have passed 🎉

github-actions[bot] avatar May 16 '23 14:05 github-actions[bot]