fix: Api response last line truncated

[CKanishka]

trafficstars

Description

The last line of the API response was getting truncated because the height assigned to the response container didn't consider a margin of 20px(10px + 10px) applied to the Response Type tabs. Fix: Updated the height to include the 20px offset.

PR fixes following issue(s)

Fixes #21198

Media

https://user-images.githubusercontent.com/30779692/236912525-953aeac9-3562-497f-9ea1-d829ada49d17.mov

Type of change

• Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

• [x] Manual
• [ ] Jest
• [ ] Cypress

Checklist:

Dev activity

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [ ] PR is being merged under a feature flag

QA activity:

• [ ] Speedbreak features have been covered
• [ ] Test plan covers all impacted features and areas of interest
• [ ] Test plan has been peer reviewed by project stakeholders and other QA members
• [ ] Manually tested functionality on DP
• [ ] We had an implementation alignment call with stakeholders post QA Round 2
• [ ] Cypress test cases have been added and approved by SDET/manual QA
• [ ] Added Test Plan Approved label after Cypress tests were reviewed
• [ ] Added Test Plan Approved label after JUnit tests were reviewed

[welcome[bot]]

Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗 Please make sure that you raise a review request so your code change does not go unnoticed.

[tanvibhakta]

This looks good to me!

[github-actions[bot]]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[coderabbitai[bot]]

Walkthrough

The changes made to the ApiResponseView component focus on enhancing the user interface by adjusting the CSS styling of the tab panel. Specifically, the height calculation is modified to provide more space for content visibility, thereby addressing the issue of truncated responses in the viewport. This adjustment is intended to improve user experience without altering the component's core functionality.

Changes

Files	Change Summary
app/client/src/components/editorComponents/ApiResponseView.tsx	Adjusted CSS height calculation for .react-tabs__tab-panel to enhance visibility of content.

Assessment against linked issues

Objective	Addressed	Explanation
Last line of API response is truncating in viewport (#21198)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.