appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

chore: WDS Color: refine `bgAccentHover` (light mode)

Open ichik opened this issue 1 year ago • 1 comments

Description

tl;dr Slightly darker hover for dark seeds, overall refinements in the medium, special exceptions for very light yellows. Minor fixes in utility functions.

Fixes #22921

Media

New on the left, current on the right https://user-images.githubusercontent.com/80973/236816955-2be0773f-2c51-4e53-9e61-844a61ad7f2c.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Chore (housekeeping or task changes that don't impact user perception)

How Has This Been Tested?

  • Manual

Test Plan

Initial POC refinement, no testing necessary

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

ichik avatar May 08 '23 11:05 ichik

LGTM. Let me know if I can merge this.

Please do.

ichik avatar May 09 '23 10:05 ichik