appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

feat: Added email bodyType to smtp action (#22749)

Open sanveer-osahan opened this issue 1 year ago • 15 comments

Description

Added a new field bodyType to SMTP action. The bodyType field specifies the content-type for email body. Users can choose between 2 options

  • Plain Text (text/plain)
  • HTML (text/html)

PR fixes following issue(s)

Fixes #22749

Type of change

  • New feature (non-breaking change which adds functionality)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. Delete anything that is not relevant

  • [ ] Manual
  • [ ] Jest
  • [ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

sanveer-osahan avatar May 08 '23 11:05 sanveer-osahan

PR Summary

  • Added "Body Type" field to SMTP plugin's editor A new field called "Body Type" has been added to the SMTP plugin's editor for better email formatting options.
  • Updated existing SMTP-plugin actions All unpublished and published SMTP-plugin actions that don't have a "Body Type" set have been updated with a default value of "text/html" for consistent email rendering.

what-the-diff[bot] avatar May 08 '23 11:05 what-the-diff[bot]

/ok-to-test

sanveer-osahan avatar May 08 '23 11:05 sanveer-osahan

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4914516065. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23078. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23078&runId=4914516065_1

github-actions[bot] avatar May 08 '23 11:05 github-actions[bot]

/ok-to-test

sanveer-osahan avatar May 08 '23 15:05 sanveer-osahan

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4917082138. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23078. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23078&runId=4917082138_1

github-actions[bot] avatar May 08 '23 15:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4917082138. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug22281_WelcomeTour_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 08 '23 17:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4917082138. Commit: ``. All cypress tests have passed 🎉

github-actions[bot] avatar May 09 '23 03:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4917082138. Commit: ``. All cypress tests have passed 🎉

github-actions[bot] avatar May 09 '23 06:05 github-actions[bot]

/ok-to-test

sanveer-osahan avatar May 10 '23 05:05 sanveer-osahan

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4933491659. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23078. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23078&runId=4933491659_1

github-actions[bot] avatar May 10 '23 05:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4933491659. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 10 '23 07:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4933491659. Commit: ``. All cypress tests have passed 🎉

github-actions[bot] avatar May 10 '23 08:05 github-actions[bot]

/build-deploy-preview

sanveer-osahan avatar May 10 '23 11:05 sanveer-osahan

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4936352472. Workflow: On demand build Docker image and deploy preview. skip-tests: . env: . PR: 23078. recreate: .

github-actions[bot] avatar May 10 '23 11:05 github-actions[bot]

Deploy-Preview-URL: https://ce-23078.dp.appsmith.com

github-actions[bot] avatar May 10 '23 11:05 github-actions[bot]

HI @sanveer-osahan Enhancement : When the user selects the type of Body we can show the watermark in the Body field respectively this will enhance our user experience.

prapullc avatar May 11 '23 04:05 prapullc