appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

[Bug]: Git sync modal shows uncommitted changes after connecting app to git.

Open Parthvi12 opened this issue 1 year ago • 4 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Description

https://user-images.githubusercontent.com/80334441/236770355-73fc2234-8b3a-4a81-8d3b-000dbdc4733c.mov

Steps To Reproduce

  1. Fork template 'Maintenance Order Management'
  2. Connect app to git
  3. Observe uncommitted changes are shown.

Public Sample App

No response

Environment

Release

Issue video log

No response

Version

Release

Parthvi12 avatar May 08 '23 08:05 Parthvi12

@Parthvi12 Can you share the diff? What changes are committed to the repo?

AnaghHegde avatar May 08 '23 09:05 AnaghHegde

@AnaghHegde : https://github.com/Parthvi12/test-123/commit/d8fcbcde468c3d105567c113e286bf1dbbc29c5e and this is initial commit: https://github.com/Parthvi12/test-123/commit/3ef2a2e0c66521b3d27308f6eaaa8554628180de

Parthvi12 avatar May 08 '23 09:05 Parthvi12

The datasource was deleted from the repo. Any operations was done to remove the datasource from the application?

AnaghHegde avatar May 08 '23 09:05 AnaghHegde

@AnaghHegde Yes on committing changes the datasource gets deleted but I didn't delete it from app as you can see in recording, I am able to reproduce this issue after connecting 'Maintenance Order Management' template to git.

Parthvi12 avatar May 08 '23 09:05 Parthvi12

@Parthvi12 - is this still reproducable?

infinitetrooper avatar Nov 24 '23 11:11 infinitetrooper

@infinitetrooper This issue is still reproducible

RakshaKShetty avatar Apr 23 '24 05:04 RakshaKShetty

While the maintenance order management template needs to be cleaned up to not require an extra commit, on the git front, we need to check why this is requiring an extra commit from the user as well. However, considering that this would mostly only impact templates/blocks, lowering the priority and disassociating from clean up.

nidhi-nair avatar Aug 08 '24 05:08 nidhi-nair