appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: Add app title in browser tab title when nav is set to side

Open dhruvikn opened this issue 1 year ago • 22 comments

Description

We missed out on updating the browser's tab title when we create the sidebar for app navigation. This PR fixes that.

PR fixes following issue(s)

Fixes #15949

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. Delete anything that is not relevant

  • [x] Manual
  • [ ] Jest
  • [ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

dhruvikn avatar May 08 '23 07:05 dhruvikn

/build-deploy-preview env=release

dhruvikn avatar May 08 '23 07:05 dhruvikn

PR Summary

  • Added import for getCurrentPageDescription Implemented a new import statement for the getCurrentPageDescription function.
  • Implemented selector in Sidebar component Utilized the selector in the Sidebar component to set the page description accordingly.
  • Integrated HtmlTitle into sidebar header Imported the HtmlTitle component and used it within the sidebar header, passing the current application name and page description as props.

what-the-diff[bot] avatar May 08 '23 07:05 what-the-diff[bot]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4912667793. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23066. recreate: .

github-actions[bot] avatar May 08 '23 07:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-jya0up6pj-get-appsmith.vercel.app

github-actions[bot] avatar May 08 '23 07:05 github-actions[bot]

/ok-to-test

dhruvikn avatar May 08 '23 12:05 dhruvikn

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4914939382. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23066. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23066&runId=4914939382_1

github-actions[bot] avatar May 08 '23 12:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4914939382. Commit: ``. The following are new failures, please fix them before merging the PR:

    To know the list of identified flaky tests - Refer here

    github-actions[bot] avatar May 08 '23 13:05 github-actions[bot]

    Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4914939382. Commit: ``. The following are new failures, please fix them before merging the PR:

      To know the list of identified flaky tests - Refer here

      github-actions[bot] avatar May 08 '23 21:05 github-actions[bot]

      Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4914939382. Commit: ``. The following are new failures, please fix them before merging the PR:

        To know the list of identified flaky tests - Refer here

        github-actions[bot] avatar May 09 '23 09:05 github-actions[bot]

        @dhruvikn - please merge latest & start new run. Cancelling re-rerun since time lag is past 12 hrs.

        Aishwarya-U-R avatar May 09 '23 09:05 Aishwarya-U-R

        /ok-to-test

        dhruvikn avatar May 10 '23 05:05 dhruvikn

        /build-deploy-preview env=release

        dhruvikn avatar May 10 '23 05:05 dhruvikn

        Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4933406009. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23066. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23066&runId=4933406009_1

        github-actions[bot] avatar May 10 '23 05:05 github-actions[bot]

        Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4933407562. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23066. recreate: .

        github-actions[bot] avatar May 10 '23 05:05 github-actions[bot]

        Deploy-Preview-URL: https://appsmith-pnxjs93bl-get-appsmith.vercel.app

        github-actions[bot] avatar May 10 '23 05:05 github-actions[bot]

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4933406009. Commit: ``. The following are new failures, please fix them before merging the PR:

        1. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
        To know the list of identified flaky tests - Refer here

        github-actions[bot] avatar May 10 '23 06:05 github-actions[bot]

        Observation: @dhruvikn

        • Appsmith is visible instead of app name when app is embedded or 'Show navbar' is disabled https://www.loom.com/share/7cad7b8701fb4ce0a2dc8e5375399678

        chandannkumar avatar May 10 '23 10:05 chandannkumar

        @chandannkumar issue has been fixed. Creating a new DP, please check.

        dhruvikn avatar May 10 '23 11:05 dhruvikn

        /build-deploy-preview env=release

        dhruvikn avatar May 10 '23 11:05 dhruvikn

        Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4936382752. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23066. recreate: .

        github-actions[bot] avatar May 10 '23 11:05 github-actions[bot]

        Deploy-Preview-URL: https://appsmith-9miczt2uf-get-appsmith.vercel.app

        github-actions[bot] avatar May 10 '23 11:05 github-actions[bot]

        Tested this PR and LGTM

        chandannkumar avatar May 10 '23 13:05 chandannkumar

        /ok-to-test

        dhruvikn avatar May 10 '23 19:05 dhruvikn

        Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4940479549. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23066. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23066&runId=4940479549_1

        github-actions[bot] avatar May 10 '23 19:05 github-actions[bot]

        /ok-to-test

        dhruvikn avatar May 15 '23 01:05 dhruvikn

        Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4975586553. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23066. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23066&runId=4975586553_1

        github-actions[bot] avatar May 15 '23 01:05 github-actions[bot]

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4975586553. Commit: ``. The following are new failures, please fix them before merging the PR:

        1. cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/Error_handling_spec.js
        2. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/PropertyPaneSuggestion_spec.ts
        3. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_DatePicker_Text_spec.js
        4. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/NavigateToFeatureValidation_spec.js
        5. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug15056_Spec.ts
        6. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug19893_spec.ts
        7. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
        8. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
        9. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
        10. cypress/integration/Regression_TestSuite/ClientSideTests/SettingsPane/GeneralSettings_spec.ts
        11. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Datepicker/DatePicker_With_Switch_spec.js
        12. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Form/FormReset_spec.js
        13. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Iframe/Iframe_spec.js
        14. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_Copy_Paste_Delete_spec.js
        15. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_container_spec.js
        16. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Others/IconButton_spec.js
        17. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV1/Table_Column_Resize_spec.js
        18. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/Image_resize_spec.js
        19. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/Pagesize_spec.ts
        20. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Property_JsonUpdate_spec.js
        21. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Sorting_spec.js
        22. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Widget_Copy_Paste_spec.js
        23. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/virtual_row_spec.js
        24. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/WidgetSelection_spec.js
        25. cypress/integration/Regression_TestSuite/ClientSideTests/Workspace/UpdateWorkspaceTests_spec.js
        26. cypress/integration/Regression_TestSuite/ServerSideTests/JsFunctionExecution/PlatformFn_spec.ts
        27. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
        28. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/AddWidgetTableAndBind_spec.js
        29. cypress/integration/SanitySuite/Datasources/DatasourceForm_spec.js
        To know the list of identified flaky tests - Refer here

        github-actions[bot] avatar May 15 '23 03:05 github-actions[bot]

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4975586553. Commit: ``. The following are new failures, please fix them before merging the PR:

        1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
        To know the list of identified flaky tests - Refer here

        github-actions[bot] avatar May 15 '23 06:05 github-actions[bot]

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4975586553. Commit: ``. The following are new failures, please fix them before merging the PR:

        1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
        To know the list of identified flaky tests - Refer here

        github-actions[bot] avatar May 15 '23 06:05 github-actions[bot]

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4975586553. Commit: ``. The following are new failures, please fix them before merging the PR:

        1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
        2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
        3. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
        To know the list of identified flaky tests - Refer here

        github-actions[bot] avatar May 15 '23 10:05 github-actions[bot]