appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: Added null check before logging analytics

Open arunvjn opened this issue 1 year ago • 9 comments

Description

Adds null check before logging "EDITOR_OPEN" analytics event.

PR fixes following issue(s)

Fixes #15220

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • [ ] Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

arunvjn avatar May 08 '23 05:05 arunvjn

PR Summary

  • Added a check for currentApplication before logging events This update ensures that the application is properly defined before attempting to log any events, preventing potential errors or issues due to undefined application data.

what-the-diff[bot] avatar May 08 '23 05:05 what-the-diff[bot]

/ok-to-test sha=cfa1062

arunvjn avatar May 08 '23 05:05 arunvjn

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4911930100. Workflow: Appsmith External Integration Test Workflow. Commit: cfa1062. PR: 23053. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23053&runId=4911930100_1

github-actions[bot] avatar May 08 '23 05:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4911930100. Commit: cfa1062. The following are new failures, please fix them before merging the PR:

    To know the list of identified flaky tests - Refer here

    github-actions[bot] avatar May 08 '23 07:05 github-actions[bot]

    Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4911930100. Commit: cfa1062. The following are new failures, please fix them before merging the PR:

      To know the list of identified flaky tests - Refer here

      github-actions[bot] avatar May 08 '23 09:05 github-actions[bot]

      /ok-to-test sha=7790abf

      Aishwarya-U-R avatar May 08 '23 09:05 Aishwarya-U-R

      Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4913614780. Workflow: Appsmith External Integration Test Workflow. Commit: 7790abf. PR: 23053. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23053&runId=4913614780_1

      github-actions[bot] avatar May 08 '23 09:05 github-actions[bot]

      Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4913614780. Commit: 7790abf. The following are new failures, please fix them before merging the PR:

      1. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
      To know the list of identified flaky tests - Refer here

      github-actions[bot] avatar May 08 '23 10:05 github-actions[bot]

      Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4913614780. Commit: 7790abf. All cypress tests have passed 🎉

      github-actions[bot] avatar May 08 '23 11:05 github-actions[bot]