appsmith
appsmith copied to clipboard
Fixed next working on last page table widget
Description
Added the disable condition on onClick event
PR fixes following issue(s)
Fixes # (issue number) #22477
Type of change
- Bug fix (non-breaking change which fixes an issue)
Testing
How Has This Been Tested?
- [ * ] Manual
Test Plan
- Drag & drop a Table widget
- Run a server side pagination query SELECT * FROM users ORDER BY id LIMIT {{Table2.selectedRow.pageSize}} offset {{Table2.pageOffset}}
- Enable server side pagination and configure onPageChange & Total records
- Reach to last page of the table records
Checklist:
Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Speedbreak features have been covered
- [ ] Test plan covers all impacted features and areas of interest
- [ ] Test plan has been peer reviewed by project stakeholders and other QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added
Test Plan Approvedlabel after Cypress tests were reviewed - [ ] Added
Test Plan Approvedlabel after JUnit tests were reviewed
Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗 Please make sure that you raise a review request so your code change does not go unnoticed.
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.
@keyurparalkar can you check this pr?
CC @somangshu
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.
@keyurparalkar the PR is getting stale. We need to either take this up internally, Assign to someone else, or just close the issue and send it back to icebox. Please take an action here
@somangshu I will take this up, add a cypress test to it and move it to QA
@keyurparalkar re-raise it internally if required to avoid hassle managing this external PR
/ok-to-test
/build-deploy-preview
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5440499075.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 23038.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23038&runId=5440499075_1
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5440500056.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 23038.
recreate: .
Deploy-Preview-URL: https://ce-23038.dp.appsmith.com
@harrybasra95 @keyurparalkar I can still observe the same issue on the generated DP https://www.loom.com/share/9c41f3a963894fc0a93348b8dc749038?sid=d680eb4d-d528-4b4c-89ee-eeaf29d39cd6
@chandannkumar you are seeing this because the changes were applied to Table V1 and not to v2.
@harrybasra95 can you make these changes here since we are only maintaining the version 2 of the table widget?
Closing this PR since there wasn't any activity from the contributor. Will raise the PR and move forward.