appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Fixed next working on last page table widget

Open harrybasra95 opened this issue 2 years ago • 2 comments

Description

Added the disable condition on onClick event

PR fixes following issue(s)

Fixes # (issue number) #22477

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

  • [ * ] Manual

Test Plan

  1. Drag & drop a Table widget
  2. Run a server side pagination query SELECT * FROM users ORDER BY id LIMIT {{Table2.selectedRow.pageSize}} offset {{Table2.pageOffset}}
  3. Enable server side pagination and configure onPageChange & Total records
  4. Reach to last page of the table records

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

harrybasra95 avatar May 06 '23 06:05 harrybasra95

Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗 Please make sure that you raise a review request so your code change does not go unnoticed.

welcome[bot] avatar May 06 '23 06:05 welcome[bot]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar May 13 '23 16:05 github-actions[bot]

@keyurparalkar can you check this pr?

dilippitchika avatar May 15 '23 03:05 dilippitchika

CC @somangshu

dilippitchika avatar May 15 '23 04:05 dilippitchika

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar May 22 '23 16:05 github-actions[bot]

@keyurparalkar the PR is getting stale. We need to either take this up internally, Assign to someone else, or just close the issue and send it back to icebox. Please take an action here

somangshu avatar May 23 '23 08:05 somangshu

@somangshu I will take this up, add a cypress test to it and move it to QA

keyurparalkar avatar May 23 '23 08:05 keyurparalkar

@keyurparalkar re-raise it internally if required to avoid hassle managing this external PR

somangshu avatar May 23 '23 08:05 somangshu

/ok-to-test

keyurparalkar avatar Jul 03 '23 04:07 keyurparalkar

/build-deploy-preview

keyurparalkar avatar Jul 03 '23 04:07 keyurparalkar

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5440499075. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23038. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23038&runId=5440499075_1

github-actions[bot] avatar Jul 03 '23 04:07 github-actions[bot]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5440500056. Workflow: On demand build Docker image and deploy preview. skip-tests: . env: . PR: 23038. recreate: .

github-actions[bot] avatar Jul 03 '23 04:07 github-actions[bot]

Deploy-Preview-URL: https://ce-23038.dp.appsmith.com

github-actions[bot] avatar Jul 03 '23 04:07 github-actions[bot]

@harrybasra95 @keyurparalkar I can still observe the same issue on the generated DP https://www.loom.com/share/9c41f3a963894fc0a93348b8dc749038?sid=d680eb4d-d528-4b4c-89ee-eeaf29d39cd6

chandannkumar avatar Jul 04 '23 08:07 chandannkumar

@chandannkumar you are seeing this because the changes were applied to Table V1 and not to v2.

@harrybasra95 can you make these changes here since we are only maintaining the version 2 of the table widget?

keyurparalkar avatar Jul 04 '23 08:07 keyurparalkar

Closing this PR since there wasn't any activity from the contributor. Will raise the PR and move forward.

keyurparalkar avatar Jul 05 '23 05:07 keyurparalkar