feat: eslint plugin appsmith

[berzerkeer]

Description

• eslint plugin to enfore wrapping src attributes in getAssetUrl function to support airgap.

Add a TL;DR when description is extra long (helps content team)

Fixes #23025

Media

https://user-images.githubusercontent.com/74818788/236258005-e40a991e-4808-432a-ab71-299f277d17ee.mov

Type of change

Please delete options that are not relevant.

• Chore (housekeeping or task changes that don't impact user perception)

How Has This Been Tested?

• Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [ ] PR is being merged under a feature flag

QA activity:

• [ ] Test plan has been approved by relevant developers
• [ ] Test plan has been peer reviewed by QA
• [ ] Cypress test cases have been added and approved by either SDET or manual QA
• [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
• [ ] Added Test Plan Approved label after reveiwing all Cypress test

[berzerkeer]

@KelvinOm is the author field necessary ? This is something many people will contribute on in the future if we need more set of custom rules. Should I remove it all together and keep it and as people add rules, they can add them to the author field . Thanks !

[KelvinOm]

@KelvinOm is the author field necessary ? This is something many people will contribute on in the future if we need more set of custom rules. Should I remove it all together and keep it and as people add rules, they can add them to the author field . Thanks !

Only name and version are required. In addition, there is a contributors field, so if someone wants to add information about themselves, they can modify the package.json file. I don't see a problem here.

[berzerkeer]

@KelvinOm is the author field necessary ? This is something many people will contribute on in the future if we need more set of custom rules. Should I remove it all together and keep it and as people add rules, they can add them to the author field . Thanks !

Only name and version are required. In addition, there is a contributors field, so if someone wants to add information about themselves, they can modify the package.json file. I don't see a problem here.

Nice then, I will remove the author field and also update the plugin name to eslint-custom-rules.

Edit: actually I think it would be better if we have the last word somewhat unique , rules is pretty generic and when we try to extend that we use ["rules"] and also to use the rule it would be then rules/asset-airgap-urls should we be more specific .

[github-actions[bot]]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[github-actions[bot]]

This PR has been closed because of inactivity.