appsmith
appsmith copied to clipboard
appsmithorg
chore: Merge two import export services into a single one
Description
We've ended up with two services for import and export - one for file import and another one for git import. The code is duplicated in both of the services. This PR merges the services into a single one.
Fixes #22940
Media
A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video
Type of change
- Chore (housekeeping or task changes that don't impact user perception)
How Has This Been Tested?
- Manual
- JUnit
Test Plan
Add Testsmith test cases links that relate to this PR
Issues raised during DP testing
Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
Checklist:
Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4890522087.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 23017.
recreate: .
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@nayan-rafiq Following issues are observed on DP regarding importing json in existing application
-
[x] On importing app's json say app2 on an imported app say app1, the reconnect modal comes up again of app1
- Import an app from json which has datasources , reconnect modal will come up, skip to application.
- On this imported app, import another app from inside application, observe reconnect modal appears with previously connected app.
-
[x] Not able to import json in existing app, if that json is already imported in some other app of same workspace.
- Import app's json in existing app, create new app say app2 in same workspace and try to import json again in the app2 observe error is thrown
both issues exists on release as well: https://github.com/appsmithorg/appsmith/issues/22829 , not a blocker for PR.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4897283867.
Workflow: Appsmith External Integration Test Workflow.
Commit: 1cb1840.
PR: 23017.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23017&runId=4897283867_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4897283867.
Commit: 1cb1840.
The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/uiToCode/uiToCode_spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/False_Spec.ts
@nayan
- [x] Reconnect modal is coming up for welcome tour in DP, (Edit: This behaviour is observed on release as well not a blocker for PR) refer:
https://user-images.githubusercontent.com/80334441/236733313-856d0ed9-1994-4598-8747-bc31d7acc541.mov
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4917368443.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 23017.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4923173724.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 23017.
recreate: true.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4925709318.
Workflow: Appsmith External Integration Test Workflow.
Commit: 9d3d378.
PR: 23017.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23017&runId=4925709318_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4925709318.
Commit: 9d3d378.
The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4925709318.
Commit: 9d3d378.
All cypress tests have passed 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4925709318.
Commit: 9d3d378.
All cypress tests have passed 🎉
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4929412846.
Workflow: Performance Tests Workflow.
Commit: ``.
PR: 23017.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23017&runId=4929412846_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4934095132.
Workflow: Appsmith External Integration Test Workflow.
Commit: 0c7be5b.
PR: 23017.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23017&runId=4934095132_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4934095132.
Commit: 0c7be5b.
The following are new failures, please fix them before merging the PR:
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4943604330.
Workflow: Appsmith External Integration Test Workflow.
Commit: fd856b6.
PR: 23017.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23017&runId=4943604330_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4943604330.
Commit: fd856b6.
The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/AbortAction_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/False_Spec.ts
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4943604330.
Commit: fd856b6.
The following are new failures, please fix them before merging the PR:
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4952690753.
Workflow: Appsmith External Integration Test Workflow.
Commit: 85b5a8e.
PR: 23017.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23017&runId=4952690753_1