appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: Fix/js object ads issues

Open Irongade opened this issue 1 year ago • 4 comments

This PR addresses issues raised when migrating JsObjects to new design system.

Issue link here: https://www.notion.so/appsmith/f353d8c6bd664f79ad858a42010cdfc8?v=f04cde23f6424aeb9d5a6e389cd172bd&p=6ff9af061f354a569b160157453bfb3f&pm=s

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration. Delete anything that is not important

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

Irongade avatar May 05 '23 02:05 Irongade

/build-deploy-preview env=release

tanvibhakta avatar May 10 '23 16:05 tanvibhakta

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4939443551. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23012. recreate: .

github-actions[bot] avatar May 10 '23 16:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-5szgxr43d-get-appsmith.vercel.app

github-actions[bot] avatar May 10 '23 17:05 github-actions[bot]

Screenshot 2023-05-10 at 11 25 47 PM

Removing of the logo background and border should not have been done because it doesn't match the entity explorer + the contrast doesn't work.

tanvibhakta avatar May 10 '23 17:05 tanvibhakta