appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: oracle icon path

Open AmanAgarwal041 opened this issue 2 years ago • 15 comments

Description

Oracle Icon was broken so changed the oracle icon path from oracle-db.jpg to oracle.svg.

Fixes #22980

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration. Delete anything that is not important

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

AmanAgarwal041 avatar May 04 '23 07:05 AmanAgarwal041

/ok-to-test

sumitsum avatar May 04 '23 10:05 sumitsum

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4881556987. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22986. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22986&runId=4881556987_1

github-actions[bot] avatar May 04 '23 10:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4881556987. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/UserProfile/UpdateUserPicture_spec.js
  5. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Bugs_Spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 04 '23 11:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4881556987. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/UserProfile/UpdateUserPicture_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 04 '23 12:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4881556987. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/UserProfile/UpdateUserPicture_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 04 '23 13:05 github-actions[bot]

@AmanAgarwal041 UpdateUserPicture_spec is fixed and merged into release. Would you please pull release and trigger tests again?

rohan-arthur avatar May 05 '23 06:05 rohan-arthur

/ok-to-test sha=d8cc646

AmanAgarwal041 avatar May 05 '23 07:05 AmanAgarwal041

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4891131211. Workflow: Appsmith External Integration Test Workflow. Commit: d8cc646. PR: 22986. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22986&runId=4891131211_1

github-actions[bot] avatar May 05 '23 07:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4891131211. Commit: d8cc646. The following are new failures, please fix them before merging the PR:

    To know the list of identified flaky tests - Refer here

    github-actions[bot] avatar May 05 '23 09:05 github-actions[bot]

    Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4891131211. Commit: d8cc646. The following are new failures, please fix them before merging the PR:

      To know the list of identified flaky tests - Refer here

      github-actions[bot] avatar May 05 '23 15:05 github-actions[bot]

      /ok-to-test

      sumitsum avatar May 06 '23 00:05 sumitsum

      Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4898606769. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22986. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22986&runId=4898606769_1

      github-actions[bot] avatar May 06 '23 00:05 github-actions[bot]

      Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4898606769. Commit: ``. The following are new failures, please fix them before merging the PR:

        To know the list of identified flaky tests - Refer here

        github-actions[bot] avatar May 06 '23 01:05 github-actions[bot]

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4898606769. Commit: ``. The following are new failures, please fix them before merging the PR:

          To know the list of identified flaky tests - Refer here

          github-actions[bot] avatar May 06 '23 19:05 github-actions[bot]

          Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4898606769. Commit: ``. The following are new failures, please fix them before merging the PR:

            To know the list of identified flaky tests - Refer here

            github-actions[bot] avatar May 07 '23 13:05 github-actions[bot]