appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: Add message prompt on min field

Open rajatagrawal opened this issue 2 years ago • 6 comments

Fixes #20235

This pull requests adds a prompt message to min/max/regex/errorMessage/required input validation fields. Also fixed css styling on the prompt message for these fields as well as additionally on Valid/ComputedValue fields.

The design shared by @vasanthappsmith is attached below :

image (1)

Checklist:

Dev activity

  • [x ] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

rajatagrawal avatar May 04 '23 01:05 rajatagrawal

/ok-to-test sha=a1a7aa0

rajatagrawal avatar May 04 '23 01:05 rajatagrawal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4878083591. Workflow: Appsmith External Integration Test Workflow. Commit: a1a7aa0. PR: 22977. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22977&runId=4878083591_1

github-actions[bot] avatar May 04 '23 01:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4878083591. Commit: a1a7aa0. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Scrolling_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_PropertyPane_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 04 '23 02:05 github-actions[bot]

/ok-to-test sha=3e47853

rajatagrawal avatar May 06 '23 02:05 rajatagrawal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4899111692. Workflow: Appsmith External Integration Test Workflow. Commit: 3e47853. PR: 22977. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22977&runId=4899111692_1

github-actions[bot] avatar May 06 '23 02:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4899111692. Commit: 3e47853. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad1_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 06 '23 03:05 github-actions[bot]