appsmith
appsmith copied to clipboard
appsmithorg
chore: Repo limit check visibility status not updated in DB in commit flow
Description
Type of change
- Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
- Manual
- Jest
- Cypress
Test Plan
Add Testsmith test cases links that relate to this PR
Issues raised during DP testing
Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
Checklist:
Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4874299002.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 22973.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22973&runId=4874299002_1
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4874303449.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 22973.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4879137320.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 22973.
recreate: .
- [x] Getting following error, on connecting an app to git, there are no previously git connected app in this workspace. @AnaghHegde
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4874299002. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/UserProfile/UpdateUserPicture_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Form/Form_With_CheckBox_spec.js
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4912235722.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 22973.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22973&runId=4912235722_1
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4912236871.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 22973.
recreate: .
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4912235722. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/Application/PgAdmin_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_JSObject_Postgress_Table_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Entity_Renaming_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitDiscardChange/DiscardChanges_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/SwitchBranches_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Replay_Editor_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Refactoring/Refactoring_spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Checkbox/CheckboxGroup_withQuery_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/Basic_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Array_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Binary_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/BooleanEnum_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Json_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
- cypress/integration/SanitySuite/Datasources/Arango_Basic_Spec.ts
- cypress/integration/SanitySuite/Datasources/MockDBs_Spec.ts
- cypress/integration/SanitySuite/Datasources/MsSQL_Basic_Spec.ts
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4915691713.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 22973.
recreate: .
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4915808619.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 22973.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22973&runId=4915808619_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4915808619. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/ActionSelector_JsToNonJSMode_spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/uiToCode/uiToCode_spec.ts
- [x] @AnaghHegde I added 4 public repos then made all of them private, on committing in one of the app it first shows the repo limit modal but on hard refresh and on trying to commit again, commit goes through. Refer:
https://user-images.githubusercontent.com/80334441/237013632-b7ddbca4-58fd-4fb4-8fbd-9b51f5631554.mov
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4923444012.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 22973.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4938330244.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 22973.
recreate: .
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4938462171.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 22973.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22973&runId=4938462171_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4938462171. Commit: ``. The following are new failures, please fix them before merging the PR: