appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: Fix null value for entity config filter parameters

Open Irongade opened this issue 1 year ago • 18 comments

This PR fixes null value issue in the computation of evaluatedQueryParameters.

Fixes #22949

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration. Delete anything that is not important

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

Irongade avatar May 03 '23 12:05 Irongade

/ok-to-test

rohan-arthur avatar May 05 '23 06:05 rohan-arthur

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4890646705. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22966. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22966&runId=4890646705_1

github-actions[bot] avatar May 05 '23 06:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4890646705. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/EmbedSettings/EmbedSettings_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/ViewMode_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 05 '23 08:05 github-actions[bot]

/ok-to-test

Irongade avatar May 08 '23 00:05 Irongade

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4910199489. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22966. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22966&runId=4910199489_1

github-actions[bot] avatar May 08 '23 00:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4910199489. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/BindButton_Text_WithRecaptcha_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 08 '23 02:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4910199489. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 08 '23 11:05 github-actions[bot]

/ok-to-test

Irongade avatar May 08 '23 14:05 Irongade

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4916418707. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22966. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22966&runId=4916418707_1

github-actions[bot] avatar May 08 '23 14:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4910199489. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 08 '23 15:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4916418707. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
  2. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_CurlPOSTImport_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 08 '23 16:05 github-actions[bot]

/ok-to-test

Irongade avatar May 08 '23 16:05 Irongade

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4917477269. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22966. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22966&runId=4917477269_1

github-actions[bot] avatar May 08 '23 16:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4917477269. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  2. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/BooleanEnum_Spec.ts
  3. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 08 '23 18:05 github-actions[bot]

/ok-to-test sha=d4583ff

Aishwarya-U-R avatar May 09 '23 04:05 Aishwarya-U-R

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4922488559. Workflow: Appsmith External Integration Test Workflow. Commit: d4583ff. PR: 22966. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22966&runId=4922488559_1

github-actions[bot] avatar May 09 '23 05:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4922488559. Commit: d4583ff. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 09 '23 06:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4922488559. Commit: d4583ff. All cypress tests have passed 🎉

github-actions[bot] avatar May 09 '23 08:05 github-actions[bot]