appsmith
appsmith copied to clipboard
fix: Fix null value for entity config filter parameters
This PR fixes null value issue in the computation of evaluatedQueryParameters
.
Fixes #22949
- Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration. Delete anything that is not important
- Manual
- Jest
- Cypress
Test Plan
Add Testsmith test cases links that relate to this PR
Issues raised during DP testing
Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
Checklist:
Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
/ok-to-test
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4890646705.
Workflow: Appsmith External Integration Test Workflow
.
Commit: ``.
PR: 22966.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22966&runId=4890646705_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4890646705. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/EmbedSettings/EmbedSettings_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/ViewMode_spec.js
/ok-to-test
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4910199489.
Workflow: Appsmith External Integration Test Workflow
.
Commit: ``.
PR: 22966.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22966&runId=4910199489_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4910199489. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/Binding/BindButton_Text_WithRecaptcha_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4910199489. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
/ok-to-test
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4916418707.
Workflow: Appsmith External Integration Test Workflow
.
Commit: ``.
PR: 22966.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22966&runId=4916418707_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4910199489. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4916418707. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_CurlPOSTImport_spec.js
/ok-to-test
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4917477269.
Workflow: Appsmith External Integration Test Workflow
.
Commit: ``.
PR: 22966.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22966&runId=4917477269_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4917477269. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/BooleanEnum_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
/ok-to-test sha=d4583ff
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4922488559.
Workflow: Appsmith External Integration Test Workflow
.
Commit: d4583ff
.
PR: 22966.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22966&runId=4922488559_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4922488559.
Commit: d4583ff
.
The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4922488559.
Commit: d4583ff
.
All cypress tests have passed 🎉