appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: Fix sentry errors for api content type

Open Irongade opened this issue 1 year ago • 24 comments

This PR fixes undefined headers value when user triggers an update to the API body type (specifically to the NONE tab.)

Fixes #22950 Fixes #22952

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration. Delete anything that is not important

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

Irongade avatar May 03 '23 11:05 Irongade

/ok-to-test

Irongade avatar May 08 '23 00:05 Irongade

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4910196827. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22958. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22958&runId=4910196827_1

github-actions[bot] avatar May 08 '23 00:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4910196827. Commit: ``. The following are new failures, please fix them before merging the PR:

    To know the list of identified flaky tests - Refer here

    github-actions[bot] avatar May 08 '23 02:05 github-actions[bot]

    /ok-to-test

    Irongade avatar May 08 '23 14:05 Irongade

    Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4916403334. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22958. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22958&runId=4916403334_1

    github-actions[bot] avatar May 08 '23 14:05 github-actions[bot]

    Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4916403334. Commit: ``. The following are new failures, please fix them before merging the PR:

      To know the list of identified flaky tests - Refer here

      github-actions[bot] avatar May 08 '23 16:05 github-actions[bot]

      Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4910196827. Commit: ``. The following are new failures, please fix them before merging the PR:

        To know the list of identified flaky tests - Refer here

        github-actions[bot] avatar May 08 '23 17:05 github-actions[bot]

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4910196827. Commit: ``. The following are new failures, please fix them before merging the PR:

          To know the list of identified flaky tests - Refer here

          github-actions[bot] avatar May 09 '23 01:05 github-actions[bot]

          /ci-merge-check

          nidhi-nair avatar May 09 '23 05:05 nidhi-nair

          Looks like there are some Cypress failures. Can't Merge.

          github-actions[bot] avatar May 09 '23 05:05 github-actions[bot]

          /ok-to-test

          Irongade avatar May 09 '23 08:05 Irongade

          Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4924254136. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22958. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22958&runId=4924254136_1

          github-actions[bot] avatar May 09 '23 08:05 github-actions[bot]

          Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4924254136. Commit: ``. The following are new failures, please fix them before merging the PR:

          1. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
          2. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_CurlPOSTImport_spec.js
          To know the list of identified flaky tests - Refer here

          github-actions[bot] avatar May 09 '23 10:05 github-actions[bot]

          Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4924254136. Commit: ``. The following are new failures, please fix them before merging the PR:

          1. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_CurlPOSTImport_spec.js
          To know the list of identified flaky tests - Refer here

          github-actions[bot] avatar May 09 '23 11:05 github-actions[bot]

          Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4924254136. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22958. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22958&runId=4924254136_3

          github-actions[bot] avatar May 10 '23 11:05 github-actions[bot]

          Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4924254136. Commit: ``. The following are new failures, please fix them before merging the PR:

          1. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
          To know the list of identified flaky tests - Refer here

          github-actions[bot] avatar May 10 '23 13:05 github-actions[bot]

          Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4924254136. Commit: ``. The following are new failures, please fix them before merging the PR:

            To know the list of identified flaky tests - Refer here

            github-actions[bot] avatar May 11 '23 11:05 github-actions[bot]

            Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4924254136. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22958. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22958&runId=4924254136_5

            github-actions[bot] avatar May 11 '23 11:05 github-actions[bot]

            /ok-to-test

            sneha122 avatar May 12 '23 10:05 sneha122

            Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4957814369. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22958. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22958&runId=4957814369_1

            github-actions[bot] avatar May 12 '23 10:05 github-actions[bot]

            Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4957814369. Commit: ``. The following are new failures, please fix them before merging the PR:

            1. cypress/integration/Regression_TestSuite/Application/MongoDBShoppingCart_spec.js
            2. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/ButtonWidgets_NavigateTo_validation_spec.js
            3. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
            4. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
            5. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
            6. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Tab/Tab_OnEvent_Navigation_spec.js
            7. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
            8. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
            To know the list of identified flaky tests - Refer here

            github-actions[bot] avatar May 12 '23 11:05 github-actions[bot]

            Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4957814369. Commit: ``. The following are new failures, please fix them before merging the PR:

            1. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
            To know the list of identified flaky tests - Refer here

            github-actions[bot] avatar May 12 '23 13:05 github-actions[bot]

            Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4957814369. Commit: ``. The following are new failures, please fix them before merging the PR:

              To know the list of identified flaky tests - Refer here

              github-actions[bot] avatar May 12 '23 14:05 github-actions[bot]

              /ci-merge-check

              sneha122 avatar May 15 '23 05:05 sneha122

              Looks like there are some Cypress failures. Can't Merge.

              github-actions[bot] avatar May 15 '23 05:05 github-actions[bot]

              /ok-to-test

              Irongade avatar May 15 '23 11:05 Irongade

              Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4979554987. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22958. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22958&runId=4979554987_1

              github-actions[bot] avatar May 15 '23 11:05 github-actions[bot]

              Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4979554987. Commit: ``. The following are new failures, please fix them before merging the PR:

              1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
              2. cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/CreateNewApp_spec.js
              3. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
              4. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
              To know the list of identified flaky tests - Refer here

              github-actions[bot] avatar May 15 '23 12:05 github-actions[bot]