fix: sending usage pulse when the app is private and user is logged in.
Today, when we open a private app, and the user is not logged in. We send the usage pulse and then redirect the user to the login page.
After this fix, if we hit a private app URL and the user is logged in, we will send the pulse or else redirect to the login page without sending a pulse.
Fixes # https://github.com/appsmithorg/cloud-services/issues/763
Type of change
- Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
- Manual
Test Plan
Add Testsmith test cases links that relate to this PR
Issues raised during DP testing
Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
Checklist:
Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
/ok-to-test sha=8cb93d6
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4865719127.
Workflow: Appsmith External Integration Test Workflow.
Commit: 8cb93d6.
PR: 22933.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22933&runId=4865719127_1
/ok-to-test sha=b4f8eed
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4868446057.
Workflow: Appsmith External Integration Test Workflow.
Commit: b4f8eed.
PR: 22933.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22933&runId=4868446057_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4868446057.
Commit: b4f8eed.
The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Json_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
- cypress/integration/SmokeSuite/FormLogin/EnableFormLogin_spec.js
- cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4868446057.
Commit: b4f8eed.
The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
- cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4868446057.
Commit: b4f8eed.
The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
- cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4868446057.
Commit: b4f8eed.
The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
- cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4868446057.
Commit: b4f8eed.
The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
- cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4868446057.
Commit: b4f8eed.
The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
- cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
/ok-to-test sha=e607a2e
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4874842430.
Workflow: Appsmith External Integration Test Workflow.
Commit: e607a2e.
PR: 22933.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22933&runId=4874842430_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4874842430.
Commit: e607a2e.
The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
- cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4874842430.
Commit: e607a2e.
The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
- cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4874842430.
Commit: e607a2e.
The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/UserProfile/UpdateUserPicture_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_dataIdentifierProperty_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
- cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4874842430.
Commit: e607a2e.
The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
- cypress/integration/Regression_TestSuite/ClientSideTests/UserProfile/UpdateUserPicture_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
- cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
/ok-to-test sha=f7a87ea
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4900036993.
Workflow: Appsmith External Integration Test Workflow.
Commit: f7a87ea.
PR: 22933.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22933&runId=4900036993_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4900036993.
Commit: f7a87ea.
The following are new failures, please fix them before merging the PR:
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4900036993.
Commit: f7a87ea.
The following are new failures, please fix them before merging the PR:
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4900036993.
Commit: f7a87ea.
The following are new failures, please fix them before merging the PR:
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4900036993.
Commit: f7a87ea.
The following are new failures, please fix them before merging the PR:
/ok-to-test sha=d1afea7
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4912417458.
Workflow: Appsmith External Integration Test Workflow.
Commit: d1afea7.
PR: 22933.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22933&runId=4912417458_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4912417458.
Commit: d1afea7.
The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/Binding/BindButton_Text_WithRecaptcha_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4912417458.
Commit: d1afea7.
All cypress tests have passed 🎉