appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Task: Expand auto height implementation to handle auto height use cases.

Open prsidhu opened this issue 1 year ago • 9 comments

Description

Expand auto layout implementation to handle auto height use cases. Use cases handled in this PR:

  1. Change canvas and container-like widget height on adding / removing widgets.
  2. Container height update on content change of individual props, e.g. text, checkbox groups.
  3. Tabs widget use cases - change height on tab change, shouldShowProps update.
  4. Correct modal widget height.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual
  • Jest

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

prsidhu avatar May 02 '23 20:05 prsidhu

/build-deploy-preview env=release

prsidhu avatar May 02 '23 20:05 prsidhu

/ok-to-test

prsidhu avatar May 02 '23 20:05 prsidhu

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4865384861. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22930. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22930&runId=4865384861_1

github-actions[bot] avatar May 02 '23 20:05 github-actions[bot]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4865383823. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22930. recreate: .

github-actions[bot] avatar May 02 '23 20:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-mblr7cvet-get-appsmith.vercel.app

github-actions[bot] avatar May 02 '23 20:05 github-actions[bot]

/build-deploy-preview env=release

prsidhu avatar May 03 '23 00:05 prsidhu

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4866951313. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22930. recreate: .

github-actions[bot] avatar May 03 '23 00:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-htt6y9upo-get-appsmith.vercel.app

github-actions[bot] avatar May 03 '23 00:05 github-actions[bot]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar May 10 '23 16:05 github-actions[bot]

This PR has been closed because of inactivity.

github-actions[bot] avatar May 27 '23 16:05 github-actions[bot]