appsmith
appsmith copied to clipboard
Task: Expand auto height implementation to handle auto height use cases.
Description
Expand auto layout implementation to handle auto height use cases. Use cases handled in this PR:
- Change canvas and container-like widget height on adding / removing widgets.
- Container height update on content change of individual props, e.g. text, checkbox groups.
- Tabs widget use cases - change height on tab change, shouldShowProps update.
- Correct modal widget height.
Type of change
Please delete options that are not relevant.
- New feature (non-breaking change which adds functionality)
How Has This Been Tested?
- Manual
- Jest
Checklist:
Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
/build-deploy-preview env=release
/ok-to-test
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4865384861.
Workflow: Appsmith External Integration Test Workflow
.
Commit: ``.
PR: 22930.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22930&runId=4865384861_1
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4865383823.
Workflow: On demand build Docker image and deploy preview
.
skip-tests: ``.
env: release
.
PR: 22930.
recreate: .
Deploy-Preview-URL: https://appsmith-mblr7cvet-get-appsmith.vercel.app
/build-deploy-preview env=release
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4866951313.
Workflow: On demand build Docker image and deploy preview
.
skip-tests: ``.
env: release
.
PR: 22930.
recreate: .
Deploy-Preview-URL: https://appsmith-htt6y9upo-get-appsmith.vercel.app
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.
This PR has been closed because of inactivity.