appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: gsheets entity explorer issue with viewMode fixed

Open sneha122 opened this issue 1 year ago • 10 comments

Description

This PR fixes:

  • When google sheets datasource is opened from entity explorer, it always opens in edit mode of the datasource, where as for other plugins, it opens in view mode. This PR fixes the issue with google sheets, so now when we open google sheets datasource from entity explorer, it opens up in view mode

Add a TL;DR when description is extra long (helps content team)

Fixes #20343

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

sneha122 avatar May 01 '23 07:05 sneha122

/ok-to-test

sneha122 avatar May 01 '23 07:05 sneha122

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4849450496. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22865. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22865&runId=4849450496_1

github-actions[bot] avatar May 01 '23 07:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4849450496. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Search_spec.js
  2. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Binary_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 01 '23 09:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4849450496. Commit: ``. All cypress tests have passed 🎉

github-actions[bot] avatar May 01 '23 10:05 github-actions[bot]

/build-deploy-preview

sneha122 avatar May 03 '23 06:05 sneha122

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4869137539. Workflow: On demand build Docker image and deploy preview. skip-tests: . env: . PR: 22865. recreate: .

github-actions[bot] avatar May 03 '23 06:05 github-actions[bot]

Deploy-Preview-URL: https://ce-22865.dp.appsmith.com @prapullac

github-actions[bot] avatar May 03 '23 07:05 github-actions[bot]

/build-deploy-preview

sneha122 avatar May 05 '23 13:05 sneha122

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4893667572. Workflow: On demand build Docker image and deploy preview. skip-tests: . env: . PR: 22865. recreate: .

github-actions[bot] avatar May 05 '23 13:05 github-actions[bot]

Deploy-Preview-URL: https://ce-22865.dp.appsmith.com

github-actions[bot] avatar May 05 '23 13:05 github-actions[bot]

Closing this PR as the issue has been fixed as part of https://github.com/appsmithorg/appsmith/pull/23113

sneha122 avatar May 11 '23 06:05 sneha122