appsmith
appsmith copied to clipboard
fix: gsheets entity explorer issue with viewMode fixed
Description
This PR fixes:
- When google sheets datasource is opened from entity explorer, it always opens in edit mode of the datasource, where as for other plugins, it opens in view mode. This PR fixes the issue with google sheets, so now when we open google sheets datasource from entity explorer, it opens up in view mode
Add a TL;DR when description is extra long (helps content team)
Fixes #20343
Media
A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video
Type of change
- Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
- Manual
Test Plan
Add Testsmith test cases links that relate to this PR
Issues raised during DP testing
Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
Checklist:
Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
/ok-to-test
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4849450496.
Workflow: Appsmith External Integration Test Workflow
.
Commit: ``.
PR: 22865.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22865&runId=4849450496_1
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4849450496. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Search_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Binary_Spec.ts
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4849450496. Commit: ``. All cypress tests have passed 🎉
/build-deploy-preview
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4869137539.
Workflow: On demand build Docker image and deploy preview
.
skip-tests: . env:
.
PR: 22865.
recreate: .
Deploy-Preview-URL: https://ce-22865.dp.appsmith.com @prapullac
/build-deploy-preview
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4893667572.
Workflow: On demand build Docker image and deploy preview
.
skip-tests: . env:
.
PR: 22865.
recreate: .
Deploy-Preview-URL: https://ce-22865.dp.appsmith.com
Closing this PR as the issue has been fixed as part of https://github.com/appsmithorg/appsmith/pull/23113