appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: MySQL Error Message Fix

Open PiyushPushkar02 opened this issue 1 year ago • 12 comments

Description

  • Changed the error message returned in case of an invalid username/password for MySQL.
  • Removed the exact exception from the error message returned to the user.

Fixes #13977

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual
  • JUnit

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

PiyushPushkar02 avatar May 01 '23 04:05 PiyushPushkar02

/ok-to-test sha=840683d

PiyushPushkar02 avatar May 01 '23 04:05 PiyushPushkar02

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4848538003. Workflow: Appsmith External Integration Test Workflow. Commit: 840683d. PR: 22859. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22859&runId=4848538003_1

github-actions[bot] avatar May 01 '23 04:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4848538003. Commit: 840683d. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js
  3. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Search_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 01 '23 06:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4848538003. Commit: 840683d. All cypress tests have passed 🎉

github-actions[bot] avatar May 01 '23 06:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4848538003. Commit: 840683d. All cypress tests have passed 🎉

github-actions[bot] avatar May 01 '23 07:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4848538003. Commit: 840683d. All cypress tests have passed 🎉

github-actions[bot] avatar May 01 '23 07:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4848538003. Commit: 840683d. All cypress tests have passed 🎉

github-actions[bot] avatar May 01 '23 08:05 github-actions[bot]

/ok-to-test sha=220afdb

PiyushPushkar02 avatar May 05 '23 05:05 PiyushPushkar02

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4890160706. Workflow: Appsmith External Integration Test Workflow. Commit: 220afdb. PR: 22859. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22859&runId=4890160706_1

github-actions[bot] avatar May 05 '23 05:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4890160706. Commit: 220afdb. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 05 '23 06:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4890160706. Commit: 220afdb. All cypress tests have passed 🎉

github-actions[bot] avatar May 05 '23 09:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4890160706. Commit: 220afdb. All cypress tests have passed 🎉

github-actions[bot] avatar May 05 '23 13:05 github-actions[bot]

/build-deploy-preview

prapullc avatar May 09 '23 05:05 prapullc

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4922839198. Workflow: On demand build Docker image and deploy preview. skip-tests: . env: . PR: 22859. recreate: .

github-actions[bot] avatar May 09 '23 05:05 github-actions[bot]

Deploy-Preview-URL: https://ce-22859.dp.appsmith.com

github-actions[bot] avatar May 10 '23 07:05 github-actions[bot]