appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: ADS 2.0 issue reported by QA & design team.

Open rohitagarwal88 opened this issue 2 years ago • 22 comments

This PR fixes

  1. Sentence case Product update in product update modal

  2. Fixed multiple scroll issue. Product update modal use default modal scroll

  3. Deduplicated Tag component.

  4. Reduced section font-size to 16px

  5. User profile page text converted to sentence case

  6. Display Upload Picture is coming from old ads, and fix in the old ads.

  7. Minor spacing alignment in user profile page

  8. Auth page Forget Password & Privacy Policy converted to sentence case

  9. Header User profile has cursor:pointer

  10. In Profile dropdown, Edit Profile & Sign out converted to sentence case

  11. Text converted to sentence case, New workspace, Admin settings, Join our discord, what's new, leave workspace, delete workspace, welcome tour

  12. Updated blank workspace icon Screenshot 2023-04-30 at 4 49 41 PM =========

  13. Updated Delete workspace icon

  14. Upload logo is sentence case

  15. Fixed Proceed button's spelling is incorrect in step 4 of guided tour

  16. Removed position fixed from workspace settings

  17. Alignment fixes in workspace setting to make it look consistent with Profile pages

  18. Guide tour title color fix

  19. Tooltip is missing for Help

  20. Added google & github icon

Fixes

  1. Templates issues
  2. Auth Pages & welcome screen
  3. Workspace settings
  4. Templates Details Page
  5. Profile Page
  6. Guided Tour
  7. Menu opens and closed with a 2-3 sec delay.
  8. Application page issues
  9. Menu isn’t getting dismissed which is causing a break in UI flow for actions
  10. Hover state should not be present for the user details since it isn’t a clickable element
  11. Preview is disabled
  12. Arrow for close side bar should turn towards the left
  13. Arrow for lock sidebar open should turn towards the right
  14. Unable to scroll to the bottom of the list
  15. Header - Clarifications
  16. Onboarding issues
  17. Wrong icon for edit in applications page
  18. Tooltip missing over help
  19. Go-to icon to be seen on hover

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration. Delete anything that is not important

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

rohitagarwal88 avatar Apr 30 '23 10:04 rohitagarwal88

/build-deploy-preview env=release

rohitagarwal88 avatar May 01 '23 05:05 rohitagarwal88

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4848816109. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22851. recreate: .

github-actions[bot] avatar May 01 '23 05:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-cu5xmk2e7-get-appsmith.vercel.app

github-actions[bot] avatar May 01 '23 05:05 github-actions[bot]

/build-deploy-preview env=release

rohitagarwal88 avatar May 03 '23 05:05 rohitagarwal88

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4868724375. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22851. recreate: .

github-actions[bot] avatar May 03 '23 05:05 github-actions[bot]

/build-deploy-preview env=release

rohitagarwal88 avatar May 05 '23 07:05 rohitagarwal88

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4890935911. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22851. recreate: .

github-actions[bot] avatar May 05 '23 07:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-8vv786stm-get-appsmith.vercel.app

github-actions[bot] avatar May 05 '23 07:05 github-actions[bot]

/build-deploy-preview env=release

rohitagarwal88 avatar May 07 '23 17:05 rohitagarwal88

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4908345512. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22851. recreate: .

github-actions[bot] avatar May 07 '23 17:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-9kqa2lkcy-get-appsmith.vercel.app

github-actions[bot] avatar May 07 '23 17:05 github-actions[bot]

/build-deploy-preview env=release

rohitagarwal88 avatar May 08 '23 11:05 rohitagarwal88

/build-deploy-preview env=release

rohitagarwal88 avatar May 08 '23 11:05 rohitagarwal88

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4914692065. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22851. recreate: .

github-actions[bot] avatar May 08 '23 11:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-psuaqbkf9-get-appsmith.vercel.app

github-actions[bot] avatar May 08 '23 11:05 github-actions[bot]

@akash-codemonk Profile Page: White block behind the toast is still seen. Please try with the below image file: image image

A grey BG colour is seen behind the remove button which isn’t present on release. Also, the text colour seems incorrect. @vasanthappsmith Can you please confirm?

Users list layout is broken image

Primary button to be used in the modal image

Applications page: Performance delay in menu button still exists

cursor pointer isn’t seen when a dropdown is open https://www.loom.com/share/366cc6515bbb4736b7015f97850e617d

laveena-en avatar May 10 '23 13:05 laveena-en

/build-deploy-preview env=release

rohitagarwal88 avatar May 10 '23 15:05 rohitagarwal88

Users list layout is broken --> Fixed after merging epic image

Primary button to be used in the modal -> @laveena-en : all delete button will be error button

rohitagarwal88 avatar May 10 '23 15:05 rohitagarwal88

/build-deploy-preview env=release

rohitagarwal88 avatar May 10 '23 15:05 rohitagarwal88

/build-deploy-preview env=release

rohitagarwal88 avatar May 10 '23 16:05 rohitagarwal88

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4939283868. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22851. recreate: .

github-actions[bot] avatar May 10 '23 16:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-39mn0dxfv-get-appsmith.vercel.app

github-actions[bot] avatar May 10 '23 16:05 github-actions[bot]