appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

feat: Autocompletion hints in sql editor

Open ohansFavour opened this issue 1 year ago • 50 comments

Description

This PR introduces autocompletion hints in the SQL editor

Fixes #17441

Media Screenshot 2023-05-07 at 14 31 11

Screenshot 2023-05-07 at 14 31 48

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration. Delete anything that is not important

  • Manual
  • Jest
  • Cypress

Test Plan

https://github.com/appsmithorg/TestSmith/issues/2381

Issues raised during DP testing

https://github.com/appsmithorg/appsmith/pull/22827#issuecomment-1536164809

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

ohansFavour avatar Apr 28 '23 10:04 ohansFavour

/build-deploy-preview env=release skip-tests=true

ohansFavour avatar Apr 28 '23 10:04 ohansFavour

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4829570466. Workflow: On demand build Docker image and deploy preview. skip-tests: true. env: release. PR: 22827. recreate: .

github-actions[bot] avatar Apr 28 '23 10:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-w3jeocm4s-get-appsmith.vercel.app

github-actions[bot] avatar Apr 28 '23 10:04 github-actions[bot]

/ok-to-test sha=fd3baee

ohansFavour avatar Apr 28 '23 11:04 ohansFavour

/build-deploy-preview env=release skip-tests=true

ohansFavour avatar Apr 28 '23 11:04 ohansFavour

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4829987238. Workflow: Appsmith External Integration Test Workflow. Commit: fd3baee. PR: 22827. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22827&runId=4829987238_1

github-actions[bot] avatar Apr 28 '23 11:04 github-actions[bot]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4829989126. Workflow: On demand build Docker image and deploy preview. skip-tests: true. env: release. PR: 22827. recreate: .

github-actions[bot] avatar Apr 28 '23 11:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-kzf45l2ye-get-appsmith.vercel.app

github-actions[bot] avatar Apr 28 '23 11:04 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4829987238. Commit: fd3baee. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Input/Inputv2_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_FieldProperties_spec.js
  4. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_CurlPOSTImport_spec.js
  5. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar Apr 28 '23 12:04 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4829987238. Commit: fd3baee. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Input/Inputv2_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_FieldProperties_spec.js
  4. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar Apr 29 '23 02:04 github-actions[bot]

/ok-to-test sha=249cbc7

ohansFavour avatar Apr 30 '23 10:04 ohansFavour

/build-deploy-preview env=release

ohansFavour avatar Apr 30 '23 10:04 ohansFavour

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4843854954. Workflow: Appsmith External Integration Test Workflow. Commit: 249cbc7. PR: 22827. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22827&runId=4843854954_1

github-actions[bot] avatar Apr 30 '23 10:04 github-actions[bot]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4843856866. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22827. recreate: .

github-actions[bot] avatar Apr 30 '23 10:04 github-actions[bot]

/ok-to-test sha=adac38a

ohansFavour avatar Apr 30 '23 10:04 ohansFavour

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4843893990. Workflow: Appsmith External Integration Test Workflow. Commit: adac38a. PR: 22827. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22827&runId=4843893990_1

github-actions[bot] avatar Apr 30 '23 10:04 github-actions[bot]

/build-deploy-preview env=release

ohansFavour avatar Apr 30 '23 10:04 ohansFavour

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4843895437. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22827. recreate: .

github-actions[bot] avatar Apr 30 '23 10:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-ialue3qjh-get-appsmith.vercel.app

github-actions[bot] avatar Apr 30 '23 10:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-a9dqh2tpq-get-appsmith.vercel.app

github-actions[bot] avatar Apr 30 '23 11:04 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4843854954. Commit: 249cbc7. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_CurlPOSTImport_spec.js
  2. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar Apr 30 '23 12:04 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4843893990. Commit: adac38a. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
  2. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar Apr 30 '23 12:04 github-actions[bot]

  • [x] Create database, alter database don't show up on autocomplete

ramsaptami avatar May 05 '23 12:05 ramsaptami

/build-deploy-preview env=release skip-tests=true

ohansFavour avatar May 06 '23 08:05 ohansFavour

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4900681177. Workflow: On demand build Docker image and deploy preview. skip-tests: true. env: release. PR: 22827. recreate: .

github-actions[bot] avatar May 06 '23 08:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-bdmax38tp-get-appsmith.vercel.app

github-actions[bot] avatar May 06 '23 08:05 github-actions[bot]

/ok-to-test

ohansFavour avatar May 07 '23 13:05 ohansFavour

/build-deploy-preview env=release skip-tests=true

ohansFavour avatar May 07 '23 13:05 ohansFavour

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4907532884. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22827. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22827&runId=4907532884_1

github-actions[bot] avatar May 07 '23 13:05 github-actions[bot]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4907533559. Workflow: On demand build Docker image and deploy preview. skip-tests: true. env: release. PR: 22827. recreate: .

github-actions[bot] avatar May 07 '23 13:05 github-actions[bot]