appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: add borderWidth to column space calculation

Open prsidhu opened this issue 1 year ago • 23 comments

Description

Issue: increasing border width of containers cuts off widgets and highlights along the edges. Cause: Column space calculation doesn't account for border widths.

Fix: To account for parent's border width in canvas' column space calculation, the value is passed as a new prop parentBorderWidth. Discount the value from the canvas width to rectify the calclulation

Add a TL;DR when description is extra long (helps content team)

Fixes # (issue)

  1. https://github.com/appsmithorg/appsmith/issues/22680

Media

https://user-images.githubusercontent.com/5424788/234401024-2a73865e-bb1c-4160-ab6b-53f74d17b6f9.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

prsidhu avatar Apr 25 '23 20:04 prsidhu

/build-deploy-preview env=release

prsidhu avatar Apr 25 '23 20:04 prsidhu

/ok-to-test

prsidhu avatar Apr 25 '23 20:04 prsidhu

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4802110693. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22738. recreate: .

github-actions[bot] avatar Apr 25 '23 20:04 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4802112587. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22738. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22738&runId=4802112587_1

github-actions[bot] avatar Apr 25 '23 20:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-fsqsaagve-get-appsmith.vercel.app

github-actions[bot] avatar Apr 25 '23 21:04 github-actions[bot]

/ok-to-test

prsidhu avatar Apr 26 '23 03:04 prsidhu

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4804481283. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22738. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22738&runId=4804481283_1

github-actions[bot] avatar Apr 26 '23 03:04 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4804481283. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ServerSideTests/Datasources/Redis_Basic_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar Apr 26 '23 04:04 github-actions[bot]

/ok-to-test

prsidhu avatar Apr 28 '23 15:04 prsidhu

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4832276329. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22738. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22738&runId=4832276329_1

github-actions[bot] avatar Apr 28 '23 15:04 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4832276329. Commit: ``. The following are new failures, please fix them before merging the PR:

    To know the list of identified flaky tests - Refer here

    github-actions[bot] avatar Apr 28 '23 17:04 github-actions[bot]

    Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4832276329. Commit: ``. The following are new failures, please fix them before merging the PR:

      To know the list of identified flaky tests - Refer here

      github-actions[bot] avatar Apr 28 '23 20:04 github-actions[bot]

      /ok-to-test

      prsidhu avatar Apr 28 '23 22:04 prsidhu

      Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4832276329. Commit: ``. The following are new failures, please fix them before merging the PR:

        To know the list of identified flaky tests - Refer here

        github-actions[bot] avatar Apr 28 '23 22:04 github-actions[bot]

        Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4835140259. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22738. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22738&runId=4835140259_1

        github-actions[bot] avatar Apr 28 '23 22:04 github-actions[bot]

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4835140259. Commit: ``. The following are new failures, please fix them before merging the PR:

        1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js
        2. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Search_spec.js
        To know the list of identified flaky tests - Refer here

        github-actions[bot] avatar Apr 28 '23 23:04 github-actions[bot]

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4835140259. Commit: ``. All cypress tests have passed 🎉

        github-actions[bot] avatar Apr 29 '23 03:04 github-actions[bot]

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4835140259. Commit: ``. All cypress tests have passed 🎉

        github-actions[bot] avatar Apr 29 '23 12:04 github-actions[bot]

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4835140259. Commit: ``. All cypress tests have passed 🎉

        github-actions[bot] avatar Apr 29 '23 13:04 github-actions[bot]

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4835140259. Commit: ``. All cypress tests have passed 🎉

        github-actions[bot] avatar Apr 29 '23 13:04 github-actions[bot]

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4835140259. Commit: ``. All cypress tests have passed 🎉

        github-actions[bot] avatar Apr 29 '23 14:04 github-actions[bot]

        Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4835140259. Commit: ``. All cypress tests have passed 🎉

        github-actions[bot] avatar Apr 29 '23 23:04 github-actions[bot]

        This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

        github-actions[bot] avatar May 07 '23 16:05 github-actions[bot]

        /ok-to-test

        prsidhu avatar May 15 '23 13:05 prsidhu

        Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4980696739. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 22738. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22738&runId=4980696739_1

        github-actions[bot] avatar May 15 '23 13:05 github-actions[bot]