appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: Visual changes to code inside appsmith

Open arunvjn opened this issue 1 year ago • 10 comments

Description

This PR contains some UI changes for code in Appsmith.

  • Sets font-family as ui-monospace for text in code editors and JSON viewer (used in evaluated value popup and debugger).
  • Sets font-size of text in code editors to 13px.
  • Set font-size for text in autocomplete to 11px.
  • Added line highlight to indicate the active line. This will be the focus state of JS Editor going forward.
  • Removed border-bottom for Tabs in JS Editor to keep it consistent with rest of the pages.
  • Introduces new colors as mentioned in this doc.

Add a TL;DR when description is extra long (helps content team)

Fixes #22992

Media

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual
  • Jest

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

arunvjn avatar Apr 24 '23 06:04 arunvjn

/build-deploy-preview env=release

arunvjn avatar Apr 24 '23 12:04 arunvjn

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4786238323. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22652. recreate: .

github-actions[bot] avatar Apr 24 '23 12:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-2u6odzn4q-get-appsmith.vercel.app

github-actions[bot] avatar Apr 24 '23 12:04 github-actions[bot]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar May 02 '23 16:05 github-actions[bot]

/ok-to-test sha=59d1dc1

ravikp7 avatar May 08 '23 11:05 ravikp7

/build-deploy-preview env=release

ravikp7 avatar May 08 '23 11:05 ravikp7

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4914561281. Workflow: Appsmith External Integration Test Workflow. Commit: 59d1dc1. PR: 22652. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22652&runId=4914561281_1

github-actions[bot] avatar May 08 '23 11:05 github-actions[bot]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4914562115. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22652. recreate: .

github-actions[bot] avatar May 08 '23 11:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-kuwl95ksd-get-appsmith.vercel.app

github-actions[bot] avatar May 08 '23 11:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4914561281. Commit: 59d1dc1. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 08 '23 12:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4914561281. Commit: 59d1dc1. All cypress tests have passed 🎉

github-actions[bot] avatar May 08 '23 19:05 github-actions[bot]

/build-deploy-preview env=release

ravikp7 avatar May 11 '23 05:05 ravikp7

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4944453374. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22652. recreate: .

github-actions[bot] avatar May 11 '23 05:05 github-actions[bot]

/ok-to-test sha=e6590eb

ravikp7 avatar May 11 '23 09:05 ravikp7

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4946388800. Workflow: Appsmith External Integration Test Workflow. Commit: e6590eb. PR: 22652. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22652&runId=4946388800_1

github-actions[bot] avatar May 11 '23 09:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4946388800. Commit: e6590eb. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Inspect_Element_spec.js
  5. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
  6. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 11 '23 11:05 github-actions[bot]

/ok-to-test sha=93748e4

ravikp7 avatar May 11 '23 11:05 ravikp7

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4947508284. Workflow: Appsmith External Integration Test Workflow. Commit: 93748e4. PR: 22652. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22652&runId=4947508284_1

github-actions[bot] avatar May 11 '23 11:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4947508284. Commit: 93748e4. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/Application/EchoApiCMS_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  4. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 11 '23 13:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4947508284. Commit: 93748e4. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  2. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 11 '23 16:05 github-actions[bot]