appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

GSheet Scope Drop Down Bug

Open PiyushPushkar02 opened this issue 1 year ago • 7 comments

Steps to reproduce:

  1. Create a new google sheet data source
  2. Select Read/write all google sheets scope from drop-down menu
  3. Now edit the data source name
  4. After changing the data source name click on whitespace anywhere.
  5. Issue it will change the user selected scope to default one.

PiyushPushkar02 avatar Apr 20 '23 04:04 PiyushPushkar02

This issue exists in production. I investigated the issue a little bit and it does not seem straightforward and seems like a tech debt. Since this is a legacy issue, it would make sense to de priortise the issue, not take it up as part of gsheets project at this point and we can take it up as ad hoc issue later on CC: @rohan-arthur @sbalaji1192

sneha122 avatar Apr 24 '23 12:04 sneha122

@sribalajig Please check the above comment.

sbalaji1192 avatar Apr 25 '23 06:04 sbalaji1192

@Ade :

  1. I observe that the scope of other DB changes when I click on white spaces. Refer the video for more clarity https://www.loom.com/share/74adfac867754616afdfaef4d4edd05f

prapullc avatar May 02 '23 09:05 prapullc

Hey @prapullc Thanks for this. This video actually shows that the issue has been resolved. Also, the authorization failing is a separate issue. It maybe possible that the service responsible for authorization was not working at the time or you tested this locally (dev.appsmith.com). Please add appropriate label to the PR.

Irongade avatar May 04 '23 20:05 Irongade

Hey @Irongade That is right the basic issue is solved but also please observe that when user changes the name of the DB the scope of other DB also change and navigate to the default scope.

prapullc avatar May 05 '23 02:05 prapullc

@prapullc Hi prapulla, that is expected behaviour because you haven't saved and authorized the new configuration you made. Unlike queries and Apis, Datasources don't autosave. so if you do not save them explicitly, they wont work or make use of the new config. This behaviour is also consistent with release or prod.

Hence, I'll be moving this back to needs QA. Please add appropriate label.

Irongade avatar May 05 '23 03:05 Irongade

Reopening this issue. The PR merged for this issue was creating authorization issues. The code is reverted in the PR.

AmanAgarwal041 avatar May 09 '23 14:05 AmanAgarwal041

I tried to fix this issue but it didn't get resolved. I'll try again tomorrow. I'm bumping up the complexity estimation for this issue.

cc: @rohan-arthur @sumitsum

Irongade avatar May 31 '23 18:05 Irongade