appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

[Feature]: Increase the text limit for tab titles

Open dilippitchika opened this issue 2 years ago • 20 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Summary

Today the text limit of tab widget's characters is 20 characters post which it truncates. Developer wants to increase this to ensure the text doesn't cut off Screenshot 2023-04-17 at 10 06 54 AM

Why should this be worked on?

When I am organising content in tabs, I want to be able to use longer titles for my tabs so that I can provide more descriptive labels for my app's content and improve its usability.

dilippitchika avatar Apr 17 '23 04:04 dilippitchika

@dilippitchika do you have a solution in mind?

somangshu avatar Apr 18 '23 05:04 somangshu

Not yet, i have asked client team to let us know what the names of tabs they are looking to use are. Based on that we want to understand how to change this

dilippitchika avatar Apr 18 '23 06:04 dilippitchika

Hey! Can I work on this issue?

Vishrut19 avatar Apr 20 '23 18:04 Vishrut19

Hey @Vishrut19 we are waiting for our client to suggest us the new limit, that's taking some time. Let me try to expedite it, in the mean time feel free to pick other good first issues.

dilippitchika avatar Apr 21 '23 04:04 dilippitchika

Hey folks @somangshu and @Vishrut19 the new limit for text should 25 characters or 180px, whichever is maximum

dilippitchika avatar Apr 21 '23 05:04 dilippitchika

Hey! I am interested to work on this issue. Can I do it? @dilippitchika

Vishrut19 avatar Apr 21 '23 12:04 Vishrut19

Thanks @Vishrut19 assigning to you. Please let us know if you can raise a PR in next 2-3 days.

dilippitchika avatar Apr 24 '23 05:04 dilippitchika

Sure! I will raise the PR asap.

Vishrut19 avatar Apr 24 '23 06:04 Vishrut19

@Vishrut19 if you raise a PR please let us know here, It might get missed otherwise!

somangshu avatar Apr 26 '23 06:04 somangshu

Thanks @Vishrut19 assigning to you. Please let us know if you can raise a PR in next 2-3 days.

Can you please send me some docs or something to run it locally?

Vishrut19 avatar Apr 26 '23 18:04 Vishrut19

@Vishrut19 here's the link to our client setup - https://github.com/appsmithorg/appsmith/blob/release/contributions/ClientSetup.md

Here's the link to our contribution guidelines https://github.com/appsmithorg/appsmith/blob/master/CONTRIBUTING.md

dilippitchika avatar Apr 27 '23 04:04 dilippitchika

Hey @dilippitchika if this is still open, I have a fix ready locally. Let me know if I can take it up

palashkaria avatar May 03 '23 07:05 palashkaria

Hey @palashkaria thanks, i am assigning this to you. Feel free to take it up.

dilippitchika avatar May 03 '23 12:05 dilippitchika

Hey, @palashkaria are you on discord? I need to talk to u to understand something

Vishrut19 avatar May 03 '23 13:05 Vishrut19

hi @dilippitchika, is this issue still open? If yes, can I pick this up?

mainakpandit avatar May 05 '23 17:05 mainakpandit

Hey @Vishrut19, sure let's connect, I'm at palash#4479

@dilippitchika the PR is raised (https://github.com/appsmithorg/appsmith/pull/23039), but I'm not sure how to raise a review request?

palashkaria avatar May 06 '23 06:05 palashkaria

Thanks @palashkaria, I linked the PR to the Issue. We will review this and get the ball rolling

somangshu avatar May 09 '23 12:05 somangshu

Hey @Vishrut19, sure let's connect, I'm at palash#4479

@dilippitchika the PR is raised (#23039), but I'm not sure how to raise a review request?

Hey @palashkaria! I have sent you a friend request on Discord. Please accept it.

Vishrut19 avatar May 09 '23 12:05 Vishrut19

Hey @dilippitchika! Is this issue completed?

Vishrut19 avatar May 12 '23 11:05 Vishrut19

@Vishrut19 we are reviewing the code for the PR, feel free to checkout some other good first issues

dilippitchika avatar May 12 '23 13:05 dilippitchika

Good day, @somangshu. I am new to this community and possess some experience with Java, but I am not an expert. I am interested in working on this project and would appreciate your guidance on the necessary technologies to learn and any beginner-friendly issues to get started. If you can provide assistance, it would be greatly appreciated and would allow me to make a good start in contributing to this project.

mr-molecule avatar May 14 '23 08:05 mr-molecule

Greetings @mr-molecule, thanks for showing interest 🎉. To find issue that you could pick up, please filter by the good first issue label. You will not be able to identify if is backend / frontend, but going though the issue should give some context. Regardless, if you find an issue that you are interested in, feel free to tag me and ill get back with the info you need.

Please don't forget to read the Contribution Guidelines to learn more about how to get started

somangshu avatar May 30 '23 10:05 somangshu