appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

feat: deduplicate api pages

Open tanvibhakta opened this issue 2 years ago • 46 comments

Description

Important note that casing for a lot of (most of) the labels are coming from the server and so will only show up in the dp once the ci tests have passed and we are able to build a dp the traditional way.

Deduplicates

  • API Pages all flows - regular API and graphQL API are two different bits of code so need to be tested separately
  • Add a datasource page - every datasource functionality and styling needs to be tested
  • evaluated value popup, binding menu, and lightening menu
  • all the debugger panes (three different debugger panes - canvas, api page, query page) all need to be tested
  • all thevarious states within the panes.

https://user-images.githubusercontent.com/13763558/234367076-9b84fd18-b583-461d-9e78-f000f29f3950.mp4

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

tanvibhakta avatar Apr 05 '23 12:04 tanvibhakta

/build-deploy-preview env=release

tanvibhakta avatar Apr 13 '23 04:04 tanvibhakta

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4685622883. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22139.

github-actions[bot] avatar Apr 13 '23 04:04 github-actions[bot]

@tanvibhakta : The cursory look at the page has too many issues. Can you please fix them before I do the code review? Here is the loom https://www.loom.com/share/8f8c27db822046679345356fa507b0c1

rohitagarwal88 avatar Apr 13 '23 06:04 rohitagarwal88

Thanks Rohit! A lot of the things you mentioned are issues that are coming from the underlying design system, and I'm hoping to fix them in the upcoming days.

  • api right pane debugger width
  • colors of the empty states in primary tab are both misses from my end, I'll do them and get back to you. Thanks!

tanvibhakta avatar Apr 13 '23 06:04 tanvibhakta

/build-deploy-preview env=release

tanvibhakta avatar Apr 17 '23 18:04 tanvibhakta

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4724779809. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22139. recreate: .

github-actions[bot] avatar Apr 17 '23 18:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-ntlkyllto-get-appsmith.vercel.app

github-actions[bot] avatar Apr 17 '23 19:04 github-actions[bot]

List of known issues:

  • content-type and keys are not aligned: This issue is also present on release but much more slightly. Will be fixing this before merging
  • back button doesn't go back where it should: fixed in datasources PR
  • menu delete item is not red: dependency on design-system implementation
  • some text, the snippet button, etc don't conform to designs: need to update design-system-old

tanvibhakta avatar Apr 17 '23 19:04 tanvibhakta

/build-deploy-preview env=release

tanvibhakta avatar Apr 18 '23 06:04 tanvibhakta

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4729378656. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22139. recreate: .

github-actions[bot] avatar Apr 18 '23 06:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-6qggedcwk-get-appsmith.vercel.app

github-actions[bot] avatar Apr 18 '23 06:04 github-actions[bot]

/build-deploy-preview env=release

tanvibhakta avatar Apr 24 '23 05:04 tanvibhakta

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4782935615. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22139. recreate: .

github-actions[bot] avatar Apr 24 '23 05:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-hrnom91tq-get-appsmith.vercel.app

github-actions[bot] avatar Apr 24 '23 06:04 github-actions[bot]

/build-deploy-preview env=release

tanvibhakta avatar Apr 25 '23 14:04 tanvibhakta

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4798424254. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22139. recreate: .

github-actions[bot] avatar Apr 25 '23 14:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-5nbmfoj3r-get-appsmith.vercel.app

github-actions[bot] avatar Apr 25 '23 14:04 github-actions[bot]

/build-deploy-preview env=release

tanvibhakta avatar Apr 26 '23 04:04 tanvibhakta

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4804771987. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22139. recreate: .

github-actions[bot] avatar Apr 26 '23 04:04 github-actions[bot]

/build-deploy-preview env=release

tanvibhakta avatar Apr 28 '23 07:04 tanvibhakta

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4828107017. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22139. recreate: .

github-actions[bot] avatar Apr 28 '23 07:04 github-actions[bot]

/build-deploy-preview env=release

tanvibhakta avatar Apr 29 '23 05:04 tanvibhakta

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4837055740. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22139. recreate: .

github-actions[bot] avatar Apr 29 '23 05:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-8kut226bs-get-appsmith.vercel.app

github-actions[bot] avatar Apr 29 '23 05:04 github-actions[bot]

/build-deploy-preview env=release

tanvibhakta avatar May 01 '23 02:05 tanvibhakta

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4847895037. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22139. recreate: .

github-actions[bot] avatar May 01 '23 02:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-aw0ys2j7m-get-appsmith.vercel.app

github-actions[bot] avatar May 01 '23 03:05 github-actions[bot]

/build-deploy-preview env=release

tanvibhakta avatar May 03 '23 14:05 tanvibhakta

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4873133397. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22139. recreate: .

github-actions[bot] avatar May 03 '23 14:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-mz59jjs5c-get-appsmith.vercel.app

github-actions[bot] avatar May 03 '23 14:05 github-actions[bot]