appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

feat: [epic] appsmith design system version 2 deduplication

Open albinAppsmith opened this issue 1 year ago • 105 comments

Description

Deduplication of old components by new ads components.

https://github.com/appsmithorg/appsmith/tree/chore/deduplicate-toast https://github.com/appsmithorg/appsmith/tree/feat/deduplicate-button-and-icon https://github.com/appsmithorg/appsmith/tree/feat/deduplicate-datasources-pages https://github.com/appsmithorg/appsmith/tree/ds/refactor/auth-pages https://github.com/appsmithorg/appsmith/tree/feat/dedup-apps-page

Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration. Delete anything that is not important

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

albinAppsmith avatar Apr 03 '23 11:04 albinAppsmith

/build-deploy-preview

albinAppsmith avatar Apr 03 '23 11:04 albinAppsmith

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4595934561. Workflow: On demand build Docker image and deploy preview. skip-tests: . env: . PR: 22030.

github-actions[bot] avatar Apr 03 '23 11:04 github-actions[bot]

Deploy-Preview-URL: https://ce-22030.dp.appsmith.com

github-actions[bot] avatar Apr 03 '23 11:04 github-actions[bot]

/build-deploy-preview

albinAppsmith avatar Apr 04 '23 10:04 albinAppsmith

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4606509003. Workflow: On demand build Docker image and deploy preview. skip-tests: . env: . PR: 22030.

github-actions[bot] avatar Apr 04 '23 10:04 github-actions[bot]

Deploy-Preview-URL: https://ce-22030.dp.appsmith.com

github-actions[bot] avatar Apr 04 '23 11:04 github-actions[bot]

/ok-to-test sha=bdde6caa8440b25fd5d21f30bec1c2affe1e8142

tanvibhakta avatar Apr 04 '23 15:04 tanvibhakta

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4609810456. Workflow: Appsmith External Integration Test Workflow. Commit: bdde6caa8440b25fd5d21f30bec1c2affe1e8142. PR: 22030. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22030&runId=4609810456_1

github-actions[bot] avatar Apr 04 '23 15:04 github-actions[bot]

The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/Application/CommunityIssues_Spec.ts
  2. cypress/integration/Regression_TestSuite/Application/EchoApiCMS_spec.js
  3. cypress/integration/Regression_TestSuite/Application/ImportExportForkApplication_spec.js
  4. cypress/integration/Regression_TestSuite/Application/MongoDBShoppingCart_spec.js
  5. cypress/integration/Regression_TestSuite/Application/PgAdmin_spec.js
  6. cypress/integration/Regression_TestSuite/Application/PromisesApp_spec.js
  7. cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/Error_handling_spec.js
  8. cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/NavigateTo_spec.ts
  9. cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/PostWindowMessage_spec.ts
  10. cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/StoreValue_spec.ts
  11. cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/setInterval_spec.js
  12. cypress/integration/Regression_TestSuite/ClientSideTests/AppNavigation/NavigationSettings_spec.js
  13. cypress/integration/Regression_TestSuite/ClientSideTests/AppNavigation/SidebarCollapse_spec.js
  14. cypress/integration/Regression_TestSuite/ClientSideTests/AppNavigation/Sidebar_spec.js
  15. cypress/integration/Regression_TestSuite/ClientSideTests/AppNavigation/TopInline_spec.js
  16. cypress/integration/Regression_TestSuite/ClientSideTests/AppNavigation/TopStacked_spec.js
  17. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
  18. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_Spec.ts
  19. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/BindApi_withPageload_Input_spec.js
  20. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_API_with_List_Widget_spec.js
  21. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_Button_with_API_spec.js
  22. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_JSObject_Postgress_Table_spec.js
  23. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_MultiSelect_Button_Text_spec.js
  24. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_TableTextPagination_spec.js
  25. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_TableV2TextPagination_spec.js
  26. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_TableV2_Widget_API_Derived_Column_spec.js
  27. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_TableV2_Widget_API_Pagination_spec.js
  28. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_Table_Widget_API_Derived_Column_spec.js
  29. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_Table_Widget_API_Pagination_spec.js
  30. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_dataToTableV2WithSnipingMode_spec.js
  31. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_dataToTableWithSnipingMode_spec.js
  32. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_tableApi_spec.js
  33. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_tableV2Api_spec.js
  34. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/JSObjectToInput_Spec.ts
  35. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/JSObjectToListWidget_Spec.ts
  36. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Promises_Spec.ts
  37. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Widget_loading_spec.js
  38. cypress/integration/Regression_TestSuite/ClientSideTests/Branding/Branding_spec.js
  39. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/AbortAction_Spec.ts
  40. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/AllWidgets_Reset_Spec.ts
  41. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug14002_Spec.ts
  42. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug14987_spec.js
  43. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug15056_Spec.ts
  44. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug18035_Spec.ts
  45. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug18876_Spec.ts
  46. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug19426_spec.ts
  47. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug19982_Spec.ts
  48. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug20275_Spec.js
  49. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
  50. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/CatchBlock_Spec.ts
  51. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/DSDiscardBugs_spec.ts
  52. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/DatasourceSchema_spec.ts
  53. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/GitBugs_Spec.ts
  54. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/InvalidURL_Spec.ts
  55. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/JSParse_Spec.ts
  56. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  57. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/MultipleOnPageLoadConfirmation_Spec.ts
  58. cypress/integration/Regression_TestSuite/ClientSideTests/DynamicHeight/DynamicHeight_Invisible_Widgets_spec.ts
  59. cypress/integration/Regression_TestSuite/ClientSideTests/DynamicHeight/DynamicHeight_List_TextWidget_Spec.js
  60. cypress/integration/Regression_TestSuite/ClientSideTests/DynamicHeight/DynamicHeight_Overlap_Test_spec.ts
  61. cypress/integration/Regression_TestSuite/ClientSideTests/DynamicHeight/DynamicHeight_Tab_spec.js
  62. cypress/integration/Regression_TestSuite/ClientSideTests/EmbedSettings/EmbedSettings_spec.js
  63. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_API_Pane_spec.js
  64. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_CopyQuery_RenameDatasource_spec.js
  65. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Datasource_Structure_spec.js
  66. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_DragAndDropWidget_spec.js
  67. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Entity_Naming_conflict_spec.js
  68. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Entity_Renaming_spec.js
  69. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Long_Name_Tooltip_spec.js
  70. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Query_Datasource_spec.js
  71. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Tab_rename_Delete_spec.js
  72. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Widgets_Copy_Delete_Undo_spec.js
  73. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Widgets_spec.js
  74. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Hide_Page_spec.js
  75. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/JSEditorContextMenu_Spec.ts
  76. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Scrolling_Spec.ts
  77. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/UpdateUsersName_spec.js
  78. cypress/integration/Regression_TestSuite/ClientSideTests/FormNativeToRawTests/Mongo_spec.ts
  79. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitDiscardChange/DiscardChanges_spec.js
  80. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
  81. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/ImportEmptyRepo_spec.js
  82. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/Connection_spec.js
  83. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/DeleteBranch_spec.js
  84. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/Deploy_spec.js
  85. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/DisconnectGit_spec.js
  86. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
  87. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
  88. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/Merge_spec.js
  89. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/RegenerateSSHKey_spec.js
  90. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/RepoLimitExceededErrorModal_spec.js
  91. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/SwitchBranches_spec.js
  92. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js
  93. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitWithTheming/GitWithTheming_spec.js
  94. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Canvas_Context_Property_Pane_spec.js
  95. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Canvas_Context_Selected_Widgets_spec.js
  96. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  97. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/MaintainContext&Focus_spec.js
  98. cypress/integration/Regression_TestSuite/ClientSideTests/JSLibrary/Library_spec.ts
  99. cypress/integration/Regression_TestSuite/ClientSideTests/Linting/AsyncFunctionsBoundInSyncFields_Spec.ts
  100. cypress/integration/Regression_TestSuite/ClientSideTests/Linting/BasicLint_spec.ts
  101. cypress/integration/Regression_TestSuite/ClientSideTests/Linting/EntityPropertiesLint_spec.ts
  102. cypress/integration/Regression_TestSuite/ClientSideTests/Linting/ErrorReporting_spec.ts
  103. cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/FirstTimeUserOnboarding_spec.js
  104. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/EntityBottomBar_spec.ts
  105. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/ExportApplication_spec.js
  106. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/GlobalSearch_spec.js
  107. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Logs_spec.ts
  108. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  109. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/PageOnLoad_spec.ts
  110. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/PreviewMode_spec.js
  111. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Replay_Editor_spec.js
  112. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Replay_spec.js
  113. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/UpdateApplication_spec.js
  114. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Widget_Error_spec.js
  115. cypress/integration/Regression_TestSuite/ClientSideTests/PeekOverlay/PeekOverlay_Spec.ts
  116. cypress/integration/Regression_TestSuite/ClientSideTests/PropertyPane/PropertyPaneCTA_spec.js
  117. cypress/integration/Regression_TestSuite/ClientSideTests/PropertyPane/PropertyPane_Search_spec.ts
  118. cypress/integration/Regression_TestSuite/ClientSideTests/Refactoring/Refactoring_spec.ts
  119. cypress/integration/Regression_TestSuite/ClientSideTests/SettingsPane/EmbedSettings_spec.ts
  120. cypress/integration/Regression_TestSuite/ClientSideTests/SettingsPane/GeneralSettings_spec.ts
  121. cypress/integration/Regression_TestSuite/ClientSideTests/SettingsPane/PageSettings_spec.ts
  122. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/ForkTemplateToGitConnectedApp.js
  123. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_Existing_app_spec.js
  124. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_To_App_spec.js
  125. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
  126. cypress/integration/Regression_TestSuite/ClientSideTests/ThemingTests/Basic_spec.js
  127. cypress/integration/Regression_TestSuite/ClientSideTests/ThemingTests/ThemeReset_spec.js
  128. cypress/integration/Regression_TestSuite/ClientSideTests/ThemingTests/Theme_Default_spec.js
  129. cypress/integration/Regression_TestSuite/ClientSideTests/ThemingTests/Theme_FormWidget_spec.js
  130. cypress/integration/Regression_TestSuite/ClientSideTests/ThemingTests/Theme_MultiSelectWidget_spec.js
  131. cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js
  132. cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
  133. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Button/ButtonLintErrorValidation_spec.js
  134. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Button/Button_onClickAction_spec.js
  135. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Button/Button_spec.js
  136. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Chart/ChartDataPoint_Spec.ts
  137. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Chart/Chart_Widget_Loading_spec.js
  138. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Chart/Chart_spec.js
  139. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Checkbox/CheckboxGroup_withQuery_spec.js
  140. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Datepicker/DatePickerV2_spec.js
  141. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Datepicker/DatePicker_With_Switch_spec.js
  142. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Dropdown/DropDownWidget_value_reset_spec.js
  143. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Dropdown/Dropdown_onOptionChange_spec.js
  144. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Filepicker/FilePicker2_spec.js
  145. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Filepicker/FilePickerV2_Widget_Reskinning_spec.js
  146. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Filepicker/FilePickerV2_spec.js
  147. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Form/FormWidget_With_Input_Number.js
  148. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js
  149. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Form/FormWithSwitch_spec.js
  150. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Input/Input_Multiline_spec.js
  151. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Input/Input_OnFocus_OnBlur_spec.js
  152. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_FormBindings_spec.js
  153. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/List/List1_spec.js
  154. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/List/ListWidgetLintErrorValidation.js
  155. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Childwigets/List_FilePicker_spec.js
  156. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Childwigets/List_Select_Widgets_spec.js
  157. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Childwigets/Listv2_Button_Widget_spec.ts
  158. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/ListV2_PageNo_PageSize_spec.js
  159. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/ListV2_SerververSide_spec.js
  160. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/ListV2_nested_List_widget_spec.js
  161. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_BasicServerSideData_spec.js
  162. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_Copy_Paste_Delete_spec.js
  163. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_Meta_Hydration_ServerSide_spec.js
  164. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_dataIdentifierProperty_spec.js
  165. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_defaultSelectedItem_spec.js
  166. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_onItemClick_spec.js
  167. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Migration_Spec.js
  168. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Others/MapChart_spec.js
  169. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Others/Statbox_spec.js
  170. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/RTE/RichTextEditor_spec.js
  171. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Select/Select_TreeSelect_MultiSelect_OnFocus_OnBlur_spec.js
  172. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Tab/Tab_spec.js
  173. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV1/TableBugs_Spec.ts
  174. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV1/TableFilter1_Spec.ts
  175. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV1/Table_Derived_Column_Data_validation_spec.js
  176. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV1/Table_Property_JsonUpdate_spec.js
  177. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV1/Table_Widget_Add_button_spec.js
  178. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV1/Table_Widget_Copy_Paste_spec.js
  179. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/Add_new_row_spec.js
  180. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/Inline_editing_spec.js
  181. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Derived_Column_Data_validation_spec.js
  182. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Property_JsonUpdate_spec.js
  183. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Widget_Add_button_spec.js
  184. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Widget_Copy_Paste_spec.js
  185. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/columnTypes/checkboxCell_spec.js
  186. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/columnTypes/select_spec.js
  187. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/columnTypes/switchCell_spec.js
  188. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/inline_editing_validations_spec.js
  189. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Text/TextWidget_LintErrorValidation_spec.js
  190. cypress/integration/Regression_TestSuite/ClientSideTests/Workspace/DeleteWorkspace_spec.js
  191. cypress/integration/Regression_TestSuite/ClientSideTests/Workspace/LeaveWorkspaceTest_spec.js
  192. cypress/integration/Regression_TestSuite/ClientSideTests/Workspace/LoginFromUIApp_spec.js
  193. cypress/integration/Regression_TestSuite/ClientSideTests/Workspace/MemberRoles_Spec.ts
  194. cypress/integration/Regression_TestSuite/ClientSideTests/Workspace/ShareAppTests_spec.js
  195. cypress/integration/Regression_TestSuite/ClientSideTests/Workspace/WorkspaceImportApplication_spec.js
  196. cypress/integration/Regression_TestSuite/EnterpriseTests/AdminSettings/Admin_settings_spec.js
  197. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_All_Verb_spec.js
  198. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Bugs_Spec.js
  199. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_ContextMenu_spec.js
  200. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_CurlPOSTImport_spec.js
  201. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_DefaultContentType_spec.js
  202. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Edit_spec.js
  203. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_MultiPart_Spec.ts
  204. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Mustache_spec.js
  205. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_RequestBody_spec.js
  206. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Response_View_spec.js
  207. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Search_spec.js
  208. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Styles_spec.js
  209. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Unique_name_spec.js
  210. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/CurlImportFlow_spec.js
  211. cypress/integration/Regression_TestSuite/ServerSideTests/Datasources/Firestore_Basic_Spec.ts
  212. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
  213. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
  214. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  215. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
  216. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
  217. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/S3_Spec.js
  218. cypress/integration/Regression_TestSuite/ServerSideTests/JsFunctionExecution/Fetch_Spec.ts
  219. cypress/integration/Regression_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts
  220. cypress/integration/Regression_TestSuite/ServerSideTests/JsFunctionExecution/PlatformFn_spec.ts
  221. cypress/integration/Regression_TestSuite/ServerSideTests/JsFunctionExecution/SetTimeout_spec.ts
  222. cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/Basic_Spec.ts
  223. cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/False_Spec.ts
  224. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/APIOnLoad_Spec.ts
  225. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad1_Spec.ts
  226. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad2_Spec.ts
  227. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad_cyclic_dependency_errors_spec.js
  228. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
  229. cypress/integration/Regression_TestSuite/ServerSideTests/Params/ExecutionParams_spec.js
  230. cypress/integration/Regression_TestSuite/ServerSideTests/Params/PassingParams_Spec.ts
  231. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Array_Spec.ts
  232. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Binary_Spec.ts
  233. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/BooleanEnum_Spec.ts
  234. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Character_Spec.ts
  235. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/DateTime_Spec.ts
  236. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Json_Spec.ts
  237. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Numeric_Spec.ts
  238. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
  239. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/AddWidgetTableAndBind_spec.js
  240. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/AddWidget_spec.js
  241. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/ConfirmRunAction_spec.js
  242. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/DSDocs_Spec.ts
  243. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/EmptyDataSource_spec.js
  244. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/EvaluatedValuePopUp_spec.ts
  245. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js
  246. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
  247. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/MySQL_Spec.ts
  248. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
  249. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
  250. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_2_spec.js
  251. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/SwitchDatasource_spec.js
  252. cypress/integration/SanitySuite/Datasources/Airtable_Basic_Spec.ts
  253. cypress/integration/SanitySuite/Datasources/ArangoDataSourceStub_spec.js
  254. cypress/integration/SanitySuite/Datasources/Arango_Basic_Spec.ts
  255. cypress/integration/SanitySuite/Datasources/AuthenticatedApiDatasource_spec.js
  256. cypress/integration/SanitySuite/Datasources/DSAutosaveImprovements_spec.ts
  257. cypress/integration/SanitySuite/Datasources/DatasourceForm_spec.js
  258. cypress/integration/SanitySuite/Datasources/ElasticSearchDatasource_spec.js
  259. cypress/integration/SanitySuite/Datasources/FirestoreStub_Spec.ts
  260. cypress/integration/SanitySuite/Datasources/GoogleSheetsStub_spec.ts
  261. cypress/integration/SanitySuite/Datasources/GraphQL_spec.ts
  262. cypress/integration/SanitySuite/Datasources/MockDBs_Spec.ts
  263. cypress/integration/SanitySuite/Datasources/MongoDatasource_spec.js
  264. cypress/integration/SanitySuite/Datasources/MsSQLDataSourceStub_spec.js
  265. cypress/integration/SanitySuite/Datasources/MsSQL_Basic_Spec.ts
  266. cypress/integration/SanitySuite/Datasources/MySQLDataSourceStub_spec.js
  267. cypress/integration/SanitySuite/Datasources/MySQLNoiseTest_spec.js
  268. cypress/integration/SanitySuite/Datasources/MySQL_spec.js
  269. cypress/integration/SanitySuite/Datasources/PostgresDatasource_spec.js
  270. cypress/integration/SanitySuite/Datasources/RedshiftDataSourceStub_spec.js
  271. cypress/integration/SanitySuite/Datasources/RestApiDatasource_spec.js
  272. cypress/integration/SanitySuite/Datasources/RestApiOAuth2Validation_spec.js
  273. cypress/integration/SanitySuite/Datasources/SMTPDatasource_spec.js
  274. cypress/integration/SanitySuite/Datasources/Styles_spec.js
  275. cypress/integration/SmokeSuite/Application/ReconnectDatasource_spec.js
  276. cypress/integration/SmokeSuite/FormLogin/EnableFormLogin_spec.js
  277. cypress/integration/SmokeSuite/GenerateCRUD/Generate_Crud_New_Page_spec.ts
Identified Flaky tests

github-actions[bot] avatar Apr 04 '23 17:04 github-actions[bot]

/build-deploy-preview env=release

albinAppsmith avatar Apr 05 '23 10:04 albinAppsmith

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4617307740. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22030.

github-actions[bot] avatar Apr 05 '23 10:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-co8ne530g-get-appsmith.vercel.app

github-actions[bot] avatar Apr 05 '23 10:04 github-actions[bot]

/build-deploy-preview env=release

albinAppsmith avatar Apr 06 '23 05:04 albinAppsmith

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4625742030. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22030.

github-actions[bot] avatar Apr 06 '23 05:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-d9d6sac4m-get-appsmith.vercel.app

github-actions[bot] avatar Apr 06 '23 05:04 github-actions[bot]

Issues wrt Auth pages and welcome screens: (Tested on DP and locally)

Design:

  1. The heading size and colour of the Sign in and Sign up pages are not as per the design file.
  2. The content (text and images) in the welcome modal are not as per the design file. Design: https://zpl.io/r1eAgoe image
  3. The Start Tutorial button in the welcome modal is entirely in uppercase - not as per the design

Functionality:

  1. The third welcome screen is being skipped automatically even when I haven’t clicked on the Make your own first app button https://www.loom.com/share/78349752239a4bb9bbcefba35491b0eb
  2. The prompt of email not being configured is seen even when the service is set up
  3. Email configuration and reset password sent prompt are seen together which is contradictory in nature Loom for 2 & 3

Adding a couple more callouts:

  1. The welcome screen lacks drop down components in the welcome screen when compared to prod. Is this intentional? The Get Started button also is in a different case Prod image Branch image

  2. Welcome screens aren’t shown when a new user signs up cc: @albinAppsmith

laveena-en avatar Apr 06 '23 14:04 laveena-en

/build-deploy-preview env=release

tanvibhakta avatar Apr 22 '23 19:04 tanvibhakta

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4774437583. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22030. recreate: .

github-actions[bot] avatar Apr 22 '23 19:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-a8clmexy6-get-appsmith.vercel.app

github-actions[bot] avatar Apr 22 '23 20:04 github-actions[bot]

/build-deploy-preview env=release

albinAppsmith avatar Apr 23 '23 20:04 albinAppsmith

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4780170215. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22030. recreate: .

github-actions[bot] avatar Apr 23 '23 20:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-9ofn9dllp-get-appsmith.vercel.app

github-actions[bot] avatar Apr 23 '23 20:04 github-actions[bot]

/build-deploy-preview env=release

albinAppsmith avatar Apr 24 '23 05:04 albinAppsmith

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4782768090. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22030. recreate: .

github-actions[bot] avatar Apr 24 '23 05:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-e62m0ia0m-get-appsmith.vercel.app

github-actions[bot] avatar Apr 24 '23 05:04 github-actions[bot]

/build-deploy-preview env=release

albinAppsmith avatar Apr 25 '23 10:04 albinAppsmith

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4796517912. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 22030. recreate: .

github-actions[bot] avatar Apr 25 '23 10:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-d4ef4msae-get-appsmith.vercel.app

github-actions[bot] avatar Apr 25 '23 10:04 github-actions[bot]

/ok-to-test sha=d56572e

albinAppsmith avatar Apr 26 '23 09:04 albinAppsmith

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4807043915. Workflow: Appsmith External Integration Test Workflow. Commit: d56572e. PR: 22030. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=22030&runId=4807043915_1

github-actions[bot] avatar Apr 26 '23 09:04 github-actions[bot]