appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

feat: de-duplicate property pane components with new ADS components

Open yaldram opened this issue 2 years ago • 50 comments

Description

  • Replace property pane components with new ADS components.
  • Replace navigation settings components with new ADS components.
  • Some other minor components De-duplications.

Fixes #19391

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Manual

Test Plan

  • Compare the Property Pane with the new Visual Designs.
  • All the inputs of the Property Pane should work as expected.
  • All the inputs of the Property Pane should be keyboard accessible.
  • Compare all the icons.
  • Check working of the Explorer and Search.

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

yaldram avatar Apr 01 '23 17:04 yaldram

/build-deploy-preview env=release

yaldram avatar Apr 02 '23 06:04 yaldram

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4587380653. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 21988.

github-actions[bot] avatar Apr 02 '23 06:04 github-actions[bot]

/build-deploy-preview env=release

yaldram avatar Apr 06 '23 05:04 yaldram

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4625846455. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 21988.

github-actions[bot] avatar Apr 06 '23 05:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-fjhk21xa3-get-appsmith.vercel.app

github-actions[bot] avatar Apr 06 '23 06:04 github-actions[bot]

/build-deploy-preview env=release

yaldram avatar Apr 07 '23 09:04 yaldram

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4637192812. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 21988.

github-actions[bot] avatar Apr 07 '23 09:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-60puf4pcz-get-appsmith.vercel.app

github-actions[bot] avatar Apr 07 '23 10:04 github-actions[bot]

/build-deploy-preview env=release

yaldram avatar Apr 07 '23 10:04 yaldram

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4637494190. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 21988.

github-actions[bot] avatar Apr 07 '23 10:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-oy1yvz7uw-get-appsmith.vercel.app

github-actions[bot] avatar Apr 07 '23 10:04 github-actions[bot]

/build-deploy-preview env=release

yaldram avatar Apr 11 '23 09:04 yaldram

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4666101940. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 21988.

github-actions[bot] avatar Apr 11 '23 09:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-okl3or0ur-get-appsmith.vercel.app

github-actions[bot] avatar Apr 11 '23 09:04 github-actions[bot]

/build-deploy-preview env=release

yaldram avatar Apr 20 '23 12:04 yaldram

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4754140447. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 21988. recreate: .

github-actions[bot] avatar Apr 20 '23 12:04 github-actions[bot]

/build-deploy-preview env=release

yaldram avatar Apr 20 '23 14:04 yaldram

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4755233394. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 21988. recreate: .

github-actions[bot] avatar Apr 20 '23 14:04 github-actions[bot]

Deploy-Preview-URL: https://appsmith-ktiltkoht-get-appsmith.vercel.app

github-actions[bot] avatar Apr 21 '23 05:04 github-actions[bot]

/build-deploy-preview env=release

akash-codemonk avatar Apr 26 '23 12:04 akash-codemonk

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4808517931. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 21988. recreate: .

github-actions[bot] avatar Apr 26 '23 12:04 github-actions[bot]

/build-deploy-preview env=release

rohitagarwal88 avatar May 01 '23 07:05 rohitagarwal88

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4849412499. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 21988. recreate: .

github-actions[bot] avatar May 01 '23 07:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-5j9s0fpk4-get-appsmith.vercel.app

github-actions[bot] avatar May 01 '23 07:05 github-actions[bot]

/build-deploy-preview env=release

yaldram avatar May 03 '23 12:05 yaldram

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4871956671. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 21988. recreate: .

github-actions[bot] avatar May 03 '23 12:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-qmwe5c814-get-appsmith.vercel.app

github-actions[bot] avatar May 03 '23 12:05 github-actions[bot]

/build-deploy-preview env=release

akash-codemonk avatar May 04 '23 10:05 akash-codemonk

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4881629436. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 21988. recreate: .

github-actions[bot] avatar May 04 '23 10:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-inkfgteva-get-appsmith.vercel.app

github-actions[bot] avatar May 04 '23 10:05 github-actions[bot]