appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

[Feature]: Extend peek overlay to include nested properties + perf improvments

Open eco-monk opened this issue 2 years ago • 1 comments
trafficstars

Is there an existing issue for this?

  • [X] I have searched the existing issues

Summary

Right now, we only support peeking global entities and their known properties (Table.data). We'd like to extend it so it supports peeking Table1.data[0].id

  • [x] #21947
  • [x] #22745
  • [ ] #23054
  • [ ] #23059
  • [ ] #23057
  • [ ] #23058

Why should this be worked on?

  • user's can make use of the peek overlay to it's full extent, giving them a great debugging experience
  • performance improvements #21467

eco-monk avatar Mar 21 '23 05:03 eco-monk

Discussion notes:

  • use AST/code mirror lexical data to identify expression
  • send it to evaluation to get value (be wary of perf issues, trigger eval only when required)
  • local variables/usage of local variables in expressions are still in the grey (need to figure what to do about them - explore AST to identify them to start with???)
  • codemirror v6 upgrade is in the plans, consider that while exploring/working on this

cc: @hetunandu @arunvjn

eco-monk avatar Mar 24 '23 10:03 eco-monk