appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: Fix for using charset from response headers instead of default UTF-8

Open balachandarsv opened this issue 2 years ago • 6 comments

Description

The REST-API response content are by default parsed in UTF-8 irrespective of what the response content-type header charset is sent.

Fixes #

Checks for any charset mentioned in response headers, if mentioned, it used the charset otherwise defaults to UTF-8

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

balachandarsv avatar Feb 22 '23 08:02 balachandarsv

Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗 Please make sure that you raise a review request so your code change does not go unnoticed.

welcome[bot] avatar Feb 22 '23 08:02 welcome[bot]

@balachandarsv is attempting to deploy a commit to the Appsmith Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 22 '23 08:02 vercel[bot]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar Mar 01 '23 16:03 github-actions[bot]

This PR has been closed because of inactivity.

github-actions[bot] avatar Mar 09 '23 16:03 github-actions[bot]

@balachandarsv Thank you for opening this PR. Apologies that it slipped through the cracks. I've reopened the PR and we'll work to merge this in. In the meantime, can I request you to please open a Github issue for this?

mohanarpit avatar Mar 29 '23 20:03 mohanarpit

Hi @balachandarsv , please mention if you are still working on this PR.

sumitsum avatar May 10 '23 11:05 sumitsum