appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

chore: datasourcecontextservice refactor

Open sondermanish opened this issue 2 years ago • 1 comments

Description

In order to account for multiple environments changes, the DatasourceContextServiceImpl.java methods needs refactoring to achieve minimal code duplicity.

  • [x] Create class to hold the key for dscontext maps.
  • [x] Refactor methods in order to have minimum duplicity.

Fixes #19451

Type of change

  • chore

This has been tested

  • Manual
  • Jest
  • Cypress

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

sondermanish avatar Jan 04 '23 11:01 sondermanish

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
appsmith ⬜️ Ignored (Inspect) Jan 12, 2023 at 7:26AM (UTC)

vercel[bot] avatar Jan 04 '23 11:01 vercel[bot]

/ok-to-test sha=42d6ef8

sondermanish avatar Jan 12 '23 07:01 sondermanish

/ok-to-test sha=42d6ef8

sondermanish avatar Jan 16 '23 13:01 sondermanish

@sondermanish Tested following DS Rest API SAAS INtegration (Airtable) Gsheet Postgres Mongo S3 Mysql

Got issue on gsheet (which is an issue related to local) {"responseMeta":{"status":500,"success":false,"error":{"code":5000,"message":"Internal server error while processing request"}}}

Rest worked fine.

AnandShahs123 avatar Jan 16 '23 13:01 AnandShahs123

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3930786083. Workflow: Appsmith External Integration Test Workflow. Commit: 42d6ef8. PR: 19485. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19485&runId=3930786083_1

github-actions[bot] avatar Jan 16 '23 13:01 github-actions[bot]