appsmith
appsmith copied to clipboard
appsmithorg
chore: ee clean up
Related to #15538
To enable adding a new action only for EE.
Refactored ActionTriggerType enum to an object.
So we can extend this with a new action in EE repo.
Made sure type discrimination is handled in ActionExecutionSaga properly as before.
- Introduced
ActionTriggerKeysunion type which can be used for type checking the values. - Refactored
ActionDescriptiontypes to accommodate usage of the union type instead of enum. - exported required types for usage in EE repo.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ✅ Ready (Inspect) | Visit Preview | Jan 4, 2023 at 6:14PM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3836038521.
Workflow: Appsmith External Integration Test Workflow.
Commit: eccda37.
PR: 19475.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19475&runId=3836038521_1
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3836124535.
Workflow: Appsmith External Integration Test Workflow.
Commit: fe027d7.
PR: 19475.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19475&runId=3836124535_1
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3838203177.
Workflow: Appsmith External Integration Test Workflow.
Commit: affe6b7.
PR: 19475.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19475&runId=3838203177_1
The following are new failures, please fix them before merging the PR
The following are new failures, please fix them before merging the PR
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3840477253.
Workflow: Appsmith External Integration Test Workflow.
Commit: e3d03b2.
PR: 19475.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19475&runId=3840477253_1
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/EmptyDataSource_spec.js
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/EmptyDataSource_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/EmptyDataSource_spec.js
Thanks @rimildeyjsr.! We now know, action selector refactor doesn't get affected by this change.
We are looking for alternate ways, instead of using union type. We'd like to use a enum/constant type. Since using string even though they're type checked looks sketchy.