appsmith
appsmith copied to clipboard
appsmithorg
chore: updated dependencies removed unused dependencies.
Description
- Add resolution for json5 dependency to resolve package vulnerabilities.
- Remove babel-plugin-styled-components because it was unused.
- Related to
react-scripts, if everything builds and dev server is running as expected we have no issues.
Fixes #19448
Media
A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video
Type of change
Please delete options that are not relevant.
- Non-breaking change.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration. Delete anything that is not important
- Manual
- Jest
- Cypress
Test Plan
- All tests need to pass.
- Does not need a regression.
Issues raised during DP testing
Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
Checklist:
Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| appsmith | ✅ Ready (Inspect) | Visit Preview | Jan 6, 2023 at 7:47AM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
- Removed babel-plugin-styled-components from package.json
- Added json5 to package.json
- Changed the optimization setting in craco config file for dev environment (minimize: false)
![what-the-diff[bot] avatar](https://avatars.githubusercontent.com/in/242248?v=4 "Published by a pub.dev verified publisher"){kind=small}
@yaldram Thank you for cleaning up the codebase. I really appreciate this.
There are a few things I'd like to ask you to add to the PR description.
- What was the issue?
- What changes have we made to resolve the issue?
- The task issue id which calls for this resolution.
- How do we know if this change breaks anything? (Which tests would tell us this)
@riodeuno I have updated the pull request description. This Pull request resolves a vulnerability, it needs no Q/A as it is related to the react-scrips dependencies, we aren't shipping this code to our customers.
@yaldram I don't see a few details in the PR:
- An issue id.
- The PR seems to say Breaking change. If this is correct, we need to elaborate on what could break.
- If we only expect existing tests to pass, we need to mention that in the tests section.
- If we need a full regression for this, we will need to mention that as well.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3829820427.
Workflow: Appsmith External Integration Test Workflow.
Commit: 8aa1e6c.
PR: 19441.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19441&runId=3829820427_1
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/Application/CommunityIssues_Spec.ts cypress/integration/Smoke_TestSuite/Application/EchoApiCMS_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Autocomplete_JS_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Scrolling_Spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitDiscardChange/DiscardChanges_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/DeleteBranch_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Git_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/SwitchBranches_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/Datasources/SMTPDatasource_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/Datatypes/MySQL_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/Datatypes/MySQL_false_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/Postgres_DataTypes/Character_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/Postgres_Spec.js
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3834643630.
Workflow: Appsmith External Integration Test Workflow.
Commit: 0321735.
PR: 19441.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19441&runId=3834643630_1
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3837413467.
Workflow: Appsmith External Integration Test Workflow.
Commit: 0321735.
PR: 19441.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19441&runId=3837413467_1
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/EmptyDataSource_spec.js
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/EmptyDataSource_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/EmptyDataSource_spec.js
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3853537836.
Workflow: Appsmith External Integration Test Workflow.
Commit: ed45952.
PR: 19441.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19441&runId=3853537836_1
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Autocomplete_JS_spec.ts
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite_Fat/ClientSideTests/Refactoring/Refactoring_spec.ts
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite_Fat/ClientSideTests/Refactoring/Refactoring_spec.ts