fix: fix git sync related bugs for Custom JS Lib feature

[sumitsum]

Description

• Fix git import / export / status related bugs. Please check out this issue for more details : https://github.com/appsmithorg/appsmith/issues/19038
• Remove feature flag usage from the server side, since it was interfering with the JUnit TCs. Please note that the overall feature is still under feature flag since the client side also uses the same feature flag.

Fixes #19038

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• Manual
• JUnit TC

Checklist:

Dev activity

• [x] My code follows the style guidelines of this project
• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [ ] PR is being merged under a feature flag

QA activity:

• [ ] Test plan has been approved by relevant developers
• [ ] Test plan has been peer reviewed by QA
• [ ] Cypress test cases have been added and approved by either SDET or manual QA
• [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
• [ ] Added Test Plan Approved label after reveiwing all Cypress test

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
appsmith	⬜️ Ignored (Inspect)		Jan 10, 2023 at 4:53AM (UTC)

[sumitsum]

/ok-to-test sha=18ea7b2

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3836102829. Workflow: Appsmith External Integration Test Workflow. Commit: 18ea7b2. PR: 19352. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19352&runId=3836102829_1

[ramsaptami]

• [ ] Change log notification does not show up for a branch - pending on Arun https://www.loom.com/share/23b2dead86f24fc895543dec6080c38a

• [ ] Error on sentry library installation

• [ ] Switching from master to branch1 on this app frequently ends up in a 404 - existing issue #not related to this DP https://jslib.appsmith.com/app/app2/page1-63986df413da8569b55c28fb/edit?branch=master

[ramsaptami]

Related test cases will be scripted by Arun post implementing front-end changes for change log Git related scenarios have been tested and verified. CC: @sumitsum @arunvjn

[AnaghHegde]

@ramsaptami I don't see the git discard scenario covered in the test plan. Can we ensure that git discard is also handled correctly?

[sumitsum]

/ok-to-test sha=eae0aa0

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3872992378. Workflow: Appsmith External Integration Test Workflow. Commit: eae0aa0. PR: 19352. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19352&runId=3872992378_1

[sumitsum]

/ok-to-test sha=58482db

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3873138452. Workflow: Appsmith External Integration Test Workflow. Commit: 58482db. PR: 19352. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19352&runId=3873138452_1

[ramsaptami]

@AnaghHegde Yep, will add those in. Thanks for reviewing!

[sumitsum]

/ok-to-test sha=4dddfdd

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3880345837. Workflow: Appsmith External Integration Test Workflow. Commit: 4dddfdd. PR: 19352. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19352&runId=3880345837_1

[github-actions[bot]]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts

[github-actions[bot]]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts

[Rhitottam]

/perf-test

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3883973779. Workflow: Performance Tests Workflow. Commit: ``. PR: 19352. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19352&runId=3883973779_1