appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: Fixed an edge case with refactoring widget names similar to template widget names

Open nidhi-nair opened this issue 2 years ago • 4 comments

Description

If a widget was being refactored from Text1 to Text2, and the same application had a List widget with a template widget of the name Text12, then the refactor logic was breaking the recalculation of dynamic binding path list. This fix checks for the complete name instead of a partial match.

Reproduction and context: https://theappsmith.slack.com/archives/C02JV8G1MP0/p1672388698340299?thread_ts=1671080059.752969&cid=C02JV8G1MP0

Fixes one cause of #10037

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual
  • Junit

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

nidhi-nair avatar Dec 30 '22 09:12 nidhi-nair

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
appsmith ⬜️ Ignored (Inspect) Dec 30, 2022 at 9:52AM (UTC)

vercel[bot] avatar Dec 30 '22 09:12 vercel[bot]

/ok-to-test sha=7fa5eab

nidhi-nair avatar Dec 30 '22 10:12 nidhi-nair

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3806408001. Workflow: Appsmith External Integration Test Workflow. Commit: 7fa5eab. PR: 19350. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19350&runId=3806408001_1

github-actions[bot] avatar Dec 30 '22 11:12 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_To_App_spec.js

github-actions[bot] avatar Dec 30 '22 12:12 github-actions[bot]

This has been tested hence moving it to done state

prapullac avatar Jan 05 '23 13:01 prapullac