appsmith
appsmith copied to clipboard
fix: Upgrade map widget library to support react 17
This PR:
- updates the react 16 to react 17
- replaces the underlying library for the map widget
- adds clustering of markers
- refactor code for map widget's component
Description
Fixes #16946
Type of change
- Breaking change
How Has This Been Tested?
- Manually
Test Plan
Add Testsmith test cases links that relate to this PR
Issues raised during DP testing
Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
Checklist:
Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
appsmith | ✅ Ready (Inspect) | Visit Preview | Jan 13, 2023 at 1:29PM (UTC) |
/ok-to-test sha=218c9f7
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3807397999.
Workflow: Appsmith External Integration Test Workflow
.
Commit: 218c9f7
.
PR: 19315.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19315&runId=3807397999_1
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_To_App_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/EmptyDataSource_spec.js
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/EmptyDataSource_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/EmptyDataSource_spec.js
@jsartisan A loading state is seen in place of the text box under Initial location.
And the corresponding location isn’t showing up on the map, on searching for a particular city. Can you please check? https://ivp6ez0ljb.vmaker.com/record/8XtxRhdwQYClpbub
Q/A Problem Areas : -
-
All Select Widgets
, need to be tested thoroughly please check this comment - https://www.loom.com/share/71564bff034847f5a82b1af9f947cb47 -
Not able to drag the select widget inside the Modal widget
- https://www.loom.com/share/e579ba0bb9d94692ba4ab2043da7efd6 - Map Widget (Already Done).
/ok-to-test sha=151a37e
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3854745148.
Workflow: Appsmith External Integration Test Workflow
.
Commit: 151a37e
.
PR: 19315.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19315&runId=3854745148_1
We still can see this issue in the modal widget, Drag to select multiple widgets is not working. @jsartisan please check this with @rahulramesha, it is related to the onClickCapture
breaking change in react 17.
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Autocomplete_JS_spec.ts
QA - The drag to select multiple widgets inside the Modal widget is fixed by Ashok, and is working as expected.
Issues and observations: @yaldram
- Issue with footer remix icons not showing up
- the clickable action for open up the Errors/logs pane is not working LOOM
/ok-to-test sha=f14aa50
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3911918276.
Workflow: Appsmith External Integration Test Workflow
.
Commit: f14aa50
.
PR: 19315.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19315&runId=3911918276_1
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/RepoLimitExceededErrorModal_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_To_App_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js