appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

feat: Improved App Navigation

Open dhruvikn opened this issue 2 years ago • 1 comments

Description

This is the PR for the EPIC #17766

Fixes #19157

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration. Delete anything that is not important

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

dhruvikn avatar Dec 29 '22 18:12 dhruvikn

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
appsmith ❌ Failed (Inspect) Mar 5, 2023 at 9:40PM (UTC)

vercel[bot] avatar Dec 29 '22 18:12 vercel[bot]

/build-deploy-preview

dhruvikn avatar Mar 02 '23 10:03 dhruvikn

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4313049862. Workflow: On demand build Docker image and deploy preview. PR: 19312.

github-actions[bot] avatar Mar 02 '23 10:03 github-actions[bot]

Deploy-Preview-URL: https://ce-19312.dp.appsmith.com

github-actions[bot] avatar Mar 02 '23 11:03 github-actions[bot]

/build-deploy-preview env=release

dhruvikn avatar Mar 17 '23 13:03 dhruvikn

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4447836091. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 19312.

github-actions[bot] avatar Mar 17 '23 13:03 github-actions[bot]

Deploy-Preview-URL: https://appsmith-lsyvsxbq3-get-appsmith.vercel.app

github-actions[bot] avatar Mar 17 '23 13:03 github-actions[bot]

/build-deploy-preview env=release

dhruvikn avatar Mar 21 '23 10:03 dhruvikn

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4477769591. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 19312.

github-actions[bot] avatar Mar 21 '23 10:03 github-actions[bot]

Deploy-Preview-URL: https://appsmith-e8a34e342-get-appsmith.vercel.app

github-actions[bot] avatar Mar 21 '23 10:03 github-actions[bot]

/ok-to-test

dhruvikn avatar Mar 21 '23 22:03 dhruvikn

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4484240255. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 19312. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19312&runId=4484240255_1

github-actions[bot] avatar Mar 21 '23 22:03 github-actions[bot]

The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/EmbedSettings/EmbedSettings_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/ThemingTests/Basic_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/ThemingTests/Theme_Default_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/ThemingTests/Theme_FormWidget_spec.js
  5. cypress/integration/Regression_TestSuite/ClientSideTests/ThemingTests/Theme_MultiSelectWidget_spec.js

github-actions[bot] avatar Mar 22 '23 04:03 github-actions[bot]

/ok-to-test

dhruvikn avatar Mar 22 '23 12:03 dhruvikn

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4490069358. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 19312. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19312&runId=4490069358_1

github-actions[bot] avatar Mar 22 '23 12:03 github-actions[bot]

The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/EmbedSettings/EmbedSettings_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/ThemingTests/Basic_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/ThemingTests/Theme_Default_spec.js
  5. cypress/integration/Regression_TestSuite/ClientSideTests/ThemingTests/Theme_FormWidget_spec.js
  6. cypress/integration/Regression_TestSuite/ClientSideTests/ThemingTests/Theme_MultiSelectWidget_spec.js
  7. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Select/Select_spec.js
  8. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Json_Spec.ts

github-actions[bot] avatar Mar 22 '23 14:03 github-actions[bot]

The following are new failures, please fix them before merging the PR:

    github-actions[bot] avatar Mar 22 '23 14:03 github-actions[bot]

    The following are new failures, please fix them before merging the PR:

      github-actions[bot] avatar Mar 22 '23 15:03 github-actions[bot]

      /ok-to-test

      dhruvikn avatar Mar 22 '23 17:03 dhruvikn

      Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4492711661. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 19312. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19312&runId=4492711661_1

      github-actions[bot] avatar Mar 22 '23 17:03 github-actions[bot]

      The following are new failures, please fix them before merging the PR:

        github-actions[bot] avatar Mar 22 '23 18:03 github-actions[bot]

        The following are new failures, please fix them before merging the PR:

          github-actions[bot] avatar Mar 22 '23 19:03 github-actions[bot]

          The following are new failures, please fix them before merging the PR:

            github-actions[bot] avatar Mar 22 '23 19:03 github-actions[bot]

            The following are new failures, please fix them before merging the PR:

              github-actions[bot] avatar Mar 22 '23 20:03 github-actions[bot]

              /ok-to-test

              dhruvikn avatar Mar 22 '23 21:03 dhruvikn

              /ok-to-test

              dhruvikn avatar Mar 22 '23 21:03 dhruvikn

              /ok-to-test

              dhruvikn avatar Mar 22 '23 22:03 dhruvikn

              /ok-to-test

              dhruvikn avatar Mar 22 '23 23:03 dhruvikn

              Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4495287817. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 19312. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19312&runId=4495287817_1

              github-actions[bot] avatar Mar 22 '23 23:03 github-actions[bot]

              The following are new failures, please fix them before merging the PR:

              1. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Select/Select_spec.js
              2. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/Pagesize_spec.ts
              3. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js

              github-actions[bot] avatar Mar 23 '23 00:03 github-actions[bot]