fix: save a query as valid if datasource has no permissions

[nsarupr]

Description

Currently a query is saved as invalid, if there are no datasource edit permissions provided. This leads to query being invalid for all the users. So, if now the edit permissions are provided to the Query, but not to the datasource, the user will be able to save the queries.

Fixes https://github.com/appsmithorg/appsmith/issues/19275

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

validateAndSaveActionToRepository_noDatasourceEditPermission

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [ ] PR is being merged under a feature flag

QA activity:

• [ ] Test plan has been approved by relevant developers
• [ ] Test plan has been peer reviewed by QA
• [ ] Cypress test cases have been added and approved by either SDET or manual QA
• [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
• [ ] Added Test Plan Approved label after reveiwing all Cypress test

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
appsmith	✅ Ready (Inspect)	Visit Preview	Jan 6, 2023 at 6:49PM (UTC)

[nsarupr]

/ok-to-test sha=acdad68

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3800225329. Workflow: Appsmith External Integration Test Workflow. Commit: acdad68. PR: 19307. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19307&runId=3800225329_1

[github-actions[bot]]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/IDE/MaintainContext&Focus_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js

[github-actions[bot]]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/IDE/MaintainContext&Focus_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js

[nsarupr]

/ok-to-test sha=6b6f0e5

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3857654371. Workflow: Appsmith External Integration Test Workflow. Commit: 6b6f0e5. PR: 19307. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19307&runId=3857654371_1

[github-actions[bot]]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts

[Parthvi12]

/ok-to-test sha=6b6f0e5

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3870787031. Workflow: Appsmith External Integration Test Workflow. Commit: 6b6f0e5. PR: 19307. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19307&runId=3870787031_1

[github-actions[bot]]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Image/Image_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts