appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

chore: code refactor for jsFunction audit log

Open rishabhrathod01 opened this issue 2 years ago • 2 comments

Description

code refactor for jsFunction audit log

Type of change

chore

How Has This Been Tested?

  • Manual
  • Jest
  • Cypress

Test Plan

No test plan required.

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

rishabhrathod01 avatar Dec 29 '22 07:12 rishabhrathod01

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Jan 9, 2023 at 5:22AM (UTC)

vercel[bot] avatar Dec 29 '22 07:12 vercel[bot]

Change in implementation

rishabhrathod01 avatar Jan 04 '23 07:01 rishabhrathod01

/ok-to-test sha=8160982

rishabhrathod01 avatar Jan 05 '23 04:01 rishabhrathod01

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3843809023. Workflow: Appsmith External Integration Test Workflow. Commit: 8160982. PR: 19297. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19297&runId=3843809023_1

github-actions[bot] avatar Jan 05 '23 04:01 github-actions[bot]

image

Latest run screenshot

rishabhrathod01 avatar Jan 05 '23 07:01 rishabhrathod01

/ok-to-test sha=210ea6e

rishabhrathod01 avatar Jan 09 '23 05:01 rishabhrathod01

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3870965785. Workflow: Appsmith External Integration Test Workflow. Commit: 210ea6e. PR: 19297. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19297&runId=3870965785_1

github-actions[bot] avatar Jan 09 '23 05:01 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Chart/Chart_Widget_Loading_spec.js

github-actions[bot] avatar Jan 09 '23 06:01 github-actions[bot]