appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: PostgreSQL Trust Authentication Login

Open PiyushPushkar02 opened this issue 3 years ago • 10 comments

Description

  • The PR removes the empty password validation check for PostgreSQL while creating a new data source.
  • The JUnit test case is added for the same. Implemented using a separate PostgreSQL container with Trust Authentication enabled for the Same.
  • Please note for testing from UI perspective we have to create a user with Trust auth enabled to validate the above changes.

Fixes #14003

Type of Change

  • Bug Fix(non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual
  • JUnit TC added

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

PiyushPushkar02 avatar Dec 28 '22 06:12 PiyushPushkar02

Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗 Please make sure that you raise a review request so your code change does not go unnoticed.

welcome[bot] avatar Dec 28 '22 06:12 welcome[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 29, 2022 at 10:28AM (UTC)

vercel[bot] avatar Dec 28 '22 06:12 vercel[bot]

@PiyushPushkar02 Can you please follow the Description and title format used here for this PR as well ? However, instead of feat we would have to use fix here. Also, when raising PR, the branch name should be either fix/something.... or feature/something... or task/something.... or chore/something.... - please take care of this in future.

sumitsum avatar Dec 28 '22 07:12 sumitsum

/ok-to-test sha=caa2485

PiyushPushkar02 avatar Dec 28 '22 09:12 PiyushPushkar02

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3792949770. Workflow: Appsmith External Integration Test Workflow. Commit: caa2485. PR: 19265. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19265&runId=3792949770_1

github-actions[bot] avatar Dec 28 '22 09:12 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_TableTextPagination_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_TableV2TextPagination_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Logs_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Button/Button_onClickAction_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Dropdown/Dropdown_onOptionChange_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/SetTimeout_spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/EmptyDataSource_spec.js

github-actions[bot] avatar Dec 28 '22 10:12 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_TableTextPagination_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_TableV2TextPagination_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Logs_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Button/Button_onClickAction_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Dropdown/Dropdown_onOptionChange_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/SetTimeout_spec.ts cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/EmptyDataSource_spec.js

github-actions[bot] avatar Dec 28 '22 11:12 github-actions[bot]

/ok-to-test sha=20fb121

PiyushPushkar02 avatar Dec 29 '22 10:12 PiyushPushkar02

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3799889040. Workflow: Appsmith External Integration Test Workflow. Commit: 20fb121. PR: 19265. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19265&runId=3799889040_1

github-actions[bot] avatar Dec 29 '22 10:12 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/IDE/MaintainContext&Focus_spec.js

github-actions[bot] avatar Dec 29 '22 11:12 github-actions[bot]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar Jan 10 '23 16:01 github-actions[bot]