appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Backend changes for error handling phase 1

Open subrata71 opened this issue 2 years ago • 10 comments

(WIP) This commit adds titles to the AppsmithErrors that don't have any

Description

  • This PR adds missing titles to the generic Appsmith errors
  • It captures downstream error messages and code where applicable for each plugin
  • It introduces a new convention for defining Appsmith error codes e.g. "PE-GEN-5000", "PE-MYS-5000"

Fixes #19019 #19061 #19063 #19064

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

subrata71 avatar Dec 27 '22 14:12 subrata71

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
appsmith ⬜️ Ignored (Inspect) Jan 4, 2023 at 8:06AM (UTC)

vercel[bot] avatar Dec 27 '22 14:12 vercel[bot]

/ok-to-test sha=c578f38

subrata71 avatar Jan 03 '23 03:01 subrata71

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3826742081. Workflow: Appsmith External Integration Test Workflow. Commit: c578f38. PR: 19258. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19258&runId=3826742081_1

github-actions[bot] avatar Jan 03 '23 03:01 github-actions[bot]

/ok-to-test sha=2e140d6

subrata71 avatar Jan 03 '23 06:01 subrata71

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3827299407. Workflow: Appsmith External Integration Test Workflow. Commit: 2e140d6. PR: 19258. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19258&runId=3827299407_1

github-actions[bot] avatar Jan 03 '23 06:01 github-actions[bot]

/ok-to-test sha=c5c5139

subrata71 avatar Jan 03 '23 07:01 subrata71

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3827550604. Workflow: Appsmith External Integration Test Workflow. Commit: c5c5139. PR: 19258. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19258&runId=3827550604_1

github-actions[bot] avatar Jan 03 '23 07:01 github-actions[bot]

/ok-to-test sha=d2671db

subrata71 avatar Jan 03 '23 07:01 subrata71

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3827634687. Workflow: Appsmith External Integration Test Workflow. Commit: d2671db. PR: 19258. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19258&runId=3827634687_1

github-actions[bot] avatar Jan 03 '23 07:01 github-actions[bot]

The following are new failures, please fix them before merging the PR

github-actions[bot] avatar Jan 03 '23 08:01 github-actions[bot]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar Jan 11 '23 16:01 github-actions[bot]

Closing this in favor of this PR

subrata71 avatar Jan 26 '23 09:01 subrata71