appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: slider widgets remove design system label component.

Open yaldram opened this issue 2 years ago • 3 comments

Description

  • Slider widgets were still using the Label component from design system package. Replace it with the Label component from widgets/components.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

yaldram avatar Dec 27 '22 10:12 yaldram

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Jan 13, 2023 at 9:09AM (UTC)

vercel[bot] avatar Dec 27 '22 10:12 vercel[bot]

Components to test -

  1. All Slider widgets.
  2. Select Widget.

yaldram avatar Dec 28 '22 12:12 yaldram

Have done regression testing all sliders and select widget

Apart from already known issue #19241, other properties for the widgets are working fine. Moving to done

Sripriya93 avatar Dec 30 '22 13:12 Sripriya93

/ok-to-test sha=9998af8

yaldram avatar Jan 09 '23 14:01 yaldram

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3874973601. Workflow: Appsmith External Integration Test Workflow. Commit: 9998af8. PR: 19246. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19246&runId=3874973601_1

github-actions[bot] avatar Jan 09 '23 14:01 github-actions[bot]

/ok-to-test sha=6c8e3fd

yaldram avatar Jan 13 '23 09:01 yaldram

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3909870451. Workflow: Appsmith External Integration Test Workflow. Commit: 6c8e3fd. PR: 19246. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19246&runId=3909870451_1

github-actions[bot] avatar Jan 13 '23 09:01 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/DatasourceSchema_spec.ts cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_Existing_app_spec.js

github-actions[bot] avatar Jan 13 '23 10:01 github-actions[bot]

The following are new failures, please fix them before merging the PR

github-actions[bot] avatar Jan 13 '23 10:01 github-actions[bot]

The following are new failures, please fix them before merging the PR

github-actions[bot] avatar Jan 13 '23 11:01 github-actions[bot]