appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

feat: [APPSMTH-30] When field is hidden in a json form allow user to set if they want to use source data as fallback

Open gitstart-appsmith opened this issue 2 years ago • 1 comments

Description

When fields is hidden in a json form, those fields value are no longer available on the widget formData. This implementation is meant to give dev the options to set if they want to use sourceData that still contains hidden fields value as fallback when some fields are hidden.

Step To Reproduce

  1. Drop a JSON form
  2. create a field and its value is present in the Jsonform1.formdata
  3. make this field invisible and its value is not present in the formdata anymore.
  4. do the same thing with a simple form, the field is present regardless of the field visiibility.

NB: This would require updating the Appsmith Documentation

Fixes #14231

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Cypress Tests

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

gitstart-appsmith avatar Dec 08 '22 20:12 gitstart-appsmith

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 29, 2022 at 2:08PM (UTC)

vercel[bot] avatar Dec 08 '22 20:12 vercel[bot]

Thank you @ashit-rath , we'd look into these reviews.

ghost avatar Dec 16 '22 17:12 ghost

/ok-to-test sha=c14a3f0

ashit-rath avatar Dec 30 '22 04:12 ashit-rath

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3804849409. Workflow: Appsmith External Integration Test Workflow. Commit: c14a3f0. PR: 18791. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18791&runId=3804849409_1

github-actions[bot] avatar Dec 30 '22 04:12 github-actions[bot]

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_To_App_spec.js

github-actions[bot] avatar Dec 30 '22 05:12 github-actions[bot]

Tested this PR and LGTM

  • Added toggle property in property pane to use Source data's hidden fields as fallback

chandannkumar avatar Jan 02 '23 11:01 chandannkumar