appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: google sheet ui issues, removed redundant code

Open AmanAgarwal041 opened this issue 2 years ago • 8 comments

Description

This Pr deals with :

  • Google Sheets UI fixes
  • Limiting users to build new query if the Google Sheet Datasource is unauthorized
  • Removal of some redundant code and moving it to one place to update the ui designs in future easily

Fixes #18032

Media Loom Video for Google Sheet Fixes

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

AmanAgarwal041 avatar Dec 08 '22 13:12 AmanAgarwal041

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 3:20PM (UTC)

vercel[bot] avatar Dec 08 '22 13:12 vercel[bot]

Deployment failed with the following error:

Resource is limited - try again in 52 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Dec 08 '22 15:12 vercel[bot]

/ok-to-test sha=a01565e

AmanAgarwal041 avatar Dec 08 '22 15:12 AmanAgarwal041

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3649631421. Workflow: Appsmith External Integration Test Workflow. Commit: a01565e. PR: 18785. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3649631421_1

github-actions[bot] avatar Dec 08 '22 15:12 github-actions[bot]

/ok-to-test sha=7329c76

AmanAgarwal041 avatar Dec 09 '22 07:12 AmanAgarwal041

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3655332956. Workflow: Appsmith External Integration Test Workflow. Commit: 7329c76. PR: 18785. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3655332956_1

github-actions[bot] avatar Dec 09 '22 07:12 github-actions[bot]

/ok-to-test sha=cb0147b

AmanAgarwal041 avatar Dec 09 '22 16:12 AmanAgarwal041

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3659094115. Workflow: Appsmith External Integration Test Workflow. Commit: cb0147b. PR: 18785. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3659094115_1

github-actions[bot] avatar Dec 09 '22 16:12 github-actions[bot]

/ok-to-test sha=6b3a573

AmanAgarwal041 avatar Dec 11 '22 06:12 AmanAgarwal041

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3667767912. Workflow: Appsmith External Integration Test Workflow. Commit: 6b3a573. PR: 18785. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3667767912_1

github-actions[bot] avatar Dec 11 '22 06:12 github-actions[bot]

/ok-to-test sha=a59c265

AmanAgarwal041 avatar Dec 12 '22 06:12 AmanAgarwal041

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3673282439. Workflow: Appsmith External Integration Test Workflow. Commit: a59c265. PR: 18785. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3673282439_1

github-actions[bot] avatar Dec 12 '22 06:12 github-actions[bot]

/ok-to-test sha=18cade4

AmanAgarwal041 avatar Dec 12 '22 11:12 AmanAgarwal041

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3675368911. Workflow: Appsmith External Integration Test Workflow. Commit: 18cade4. PR: 18785. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3675368911_1

github-actions[bot] avatar Dec 12 '22 11:12 github-actions[bot]

/ok-to-test sha=12b852c

AmanAgarwal041 avatar Dec 13 '22 06:12 AmanAgarwal041

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3682836442. Workflow: Appsmith External Integration Test Workflow. Commit: 12b852c. PR: 18785. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3682836442_1

github-actions[bot] avatar Dec 13 '22 06:12 github-actions[bot]

/ok-to-test sha=37ed165

AmanAgarwal041 avatar Dec 13 '22 11:12 AmanAgarwal041

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3685056825. Workflow: Appsmith External Integration Test Workflow. Commit: 37ed165. PR: 18785. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3685056825_1

github-actions[bot] avatar Dec 13 '22 11:12 github-actions[bot]

/ok-to-test sha=d0eb0fb

AmanAgarwal041 avatar Dec 13 '22 14:12 AmanAgarwal041

/ok-to-test sha=d0eb0fb

AmanAgarwal041 avatar Dec 14 '22 05:12 AmanAgarwal041

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3692168981. Workflow: Appsmith External Integration Test Workflow. Commit: d0eb0fb. PR: 18785. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3692168981_1

github-actions[bot] avatar Dec 14 '22 05:12 github-actions[bot]

/ok-to-test sha=f675f13

AmanAgarwal041 avatar Dec 15 '22 07:12 AmanAgarwal041

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3701982169. Workflow: Appsmith External Integration Test Workflow. Commit: f675f13. PR: 18785. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3701982169_1

github-actions[bot] avatar Dec 15 '22 07:12 github-actions[bot]

/ok-to-test sha=eda1b3e

AmanAgarwal041 avatar Dec 15 '22 16:12 AmanAgarwal041

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3705895407. Workflow: Appsmith External Integration Test Workflow. Commit: eda1b3e. PR: 18785. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3705895407_1

github-actions[bot] avatar Dec 15 '22 16:12 github-actions[bot]

/ok-to-test sha=d7b7ec8

sneha122 avatar Dec 16 '22 07:12 sneha122

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3711108592. Workflow: Appsmith External Integration Test Workflow. Commit: d7b7ec8. PR: 18785. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3711108592_1

github-actions[bot] avatar Dec 16 '22 07:12 github-actions[bot]

/ok-to-test sha=23c9b8a

sneha122 avatar Dec 17 '22 15:12 sneha122

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3720633041. Workflow: Appsmith External Integration Test Workflow. Commit: 23c9b8a. PR: 18785. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18785&runId=3720633041_1

github-actions[bot] avatar Dec 17 '22 15:12 github-actions[bot]

/perf-test

sneha122 avatar Dec 20 '22 06:12 sneha122