fix: Invalid page name validation was not clearing when the selected page is changed

[albinAppsmith]

Description

In property pane, when a user enters the invalid page name for a page and switches to an another page, the error message is not getting cleared. This PR contains the fix for this issue.

Fixes #17393

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration. Delete anything that is not important

• Manual
• Jest
• Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [] PR is being merged under a feature flag

QA activity:

• [ ] Test plan has been approved by relevant developers
• [ ] Test plan has been peer reviewed by QA
• [ ] Cypress test cases have been added and approved by either SDET or manual QA
• [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
• [ ] Added Test Plan Approved label after reveiwing all Cypress test

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
appsmith	✅ Ready (Inspect)	Visit Preview	Dec 10, 2022 at 5:37AM (UTC)

[albinAppsmith]

/ok-to-test sha=f8daedc

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3648432412. Workflow: Appsmith External Integration Test Workflow. Commit: f8daedc. PR: 18782. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18782&runId=3648432412_1

[albinAppsmith]

/ok-to-test sha=4bc740f

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3651410636. Workflow: Appsmith External Integration Test Workflow. Commit: 4bc740f. PR: 18782. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18782&runId=3651410636_1

[albinAppsmith]

Depends on https://github.com/appsmithorg/design-system/pull/272

[shadabbuchh]

1. Now error message only displays when validation is not passed and the error message does not persist when we juggle between pages
2. Also now there is an appropriate space between the error message and the next line.

https://www.loom.com/share/919ae17b4fcb45d79dec4b3a15827006

[albinAppsmith]

/ok-to-test sha=c17d58f

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3656787930. Workflow: Appsmith External Integration Test Workflow. Commit: c17d58f. PR: 18782. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18782&runId=3656787930_1

[albinAppsmith]

/ok-to-test sha=677de32

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3662849282. Workflow: Appsmith External Integration Test Workflow. Commit: 677de32. PR: 18782. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18782&runId=3662849282_1

[albinAppsmith]

Closing this PR since the changes has already gone to release via re-branding changes.