appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

chore: decomposing action execution flow methods into smaller methods

Open sondermanish opened this issue 2 years ago • 2 comments

Description

To accommodate for datasource context adaption for environments, the execute action flow needs to be changed so that the action execution flow in EE introduce minimal code diffs. Currently the executeAction method implicitly handles dsContext fetch. this method requires some rework for EE, To avoid a parallel set of method to address the dsContext fetch method rework these changes were required.

TL; DR : This Pr intends to streamline and improve code readability of action execution flow in executeAction methods by breaking the main executeAction methods into smaller methods.

Fixes #18760

Type of change

Chore

How Has This Been Tested?

  • Manual
  • Jest

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

sondermanish avatar Dec 07 '22 14:12 sondermanish

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
appsmith ⬜️ Ignored (Inspect) Dec 12, 2022 at 4:00PM (UTC)

vercel[bot] avatar Dec 07 '22 14:12 vercel[bot]

Deployment failed with the following error:

Resource is limited - try again in 39 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Dec 07 '22 14:12 vercel[bot]

/ok-to-test sha=595f028

sondermanish avatar Dec 10 '22 17:12 sondermanish

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3665125497. Workflow: Appsmith External Integration Test Workflow. Commit: 595f028. PR: 18762. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18762&runId=3665125497_1

github-actions[bot] avatar Dec 10 '22 17:12 github-actions[bot]

/ok-to-test sha=8481a84

sondermanish avatar Dec 13 '22 07:12 sondermanish

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3683064016. Workflow: Appsmith External Integration Test Workflow. Commit: 8481a84. PR: 18762. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18762&runId=3683064016_1

github-actions[bot] avatar Dec 13 '22 07:12 github-actions[bot]