appsmith
appsmith copied to clipboard
fix: datasource discard popup issue fixed
Description
When I open a datasource for editing, and hit Back without making any changes, I should not see the popup to save/discard changes.
Fixes #18664
Media https://user-images.githubusercontent.com/30018882/206202137-63bf45fb-8aa9-4867-86e6-68ee8d093b00.mov
Type of change
- Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
- Manual
- Cypress
Test Plan
Add Testsmith test cases links that relate to this PR
Issues raised during DP testing
Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
Checklist:
Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
appsmith | ✅ Ready (Inspect) | Visit Preview | Dec 9, 2022 at 6:42AM (UTC) |
/ok-to-test sha=5d7767e
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3645921322.
Workflow: Appsmith External Integration Test Workflow
.
Commit: 5d7767e
.
PR: 18761.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18761&runId=3645921322_1
/ok-to-test sha=b695f87
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3647237599.
Workflow: Appsmith External Integration Test Workflow
.
Commit: b695f87
.
PR: 18761.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18761&runId=3647237599_1
/ok-to-test sha=f0c9a22
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3655089543.
Workflow: Appsmith External Integration Test Workflow
.
Commit: f0c9a22
.
PR: 18761.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18761&runId=3655089543_1