appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: Remove auto-height from list widget's children

Open rahulramesha opened this issue 2 years ago • 6 comments

Description

This PR contains code to remove auto height capability from List Widget's children. This includes,

  • Changes to remove auto height control from property pane of list widget's Children
  • Changes to convert list widget's children to fixed height when added to list widget
  • Changes to Migrate existing list widget children to have fixed height

Fixes #18825

Media https://www.loom.com/share/405060651fe04dad89560f2a8969c409

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

rahulramesha avatar Dec 07 '22 13:12 rahulramesha

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Dec 17, 2022 at 0:32AM (UTC)

vercel[bot] avatar Dec 07 '22 13:12 vercel[bot]

@riodeuno please go through the PR and Let me know about your thoughts about the approach. There are abstraction leaks but not sure how to achieve this in another way.

rahulramesha avatar Dec 07 '22 13:12 rahulramesha

/ok-to-test sha=630b71c

riodeuno avatar Dec 09 '22 08:12 riodeuno

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3655803954. Workflow: Appsmith External Integration Test Workflow. Commit: 630b71c. PR: 18755. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18755&runId=3655803954_1

github-actions[bot] avatar Dec 09 '22 08:12 github-actions[bot]

/ok-to-test sha=6c51567

NandanAnantharamu avatar Dec 09 '22 13:12 NandanAnantharamu

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3657731532. Workflow: Appsmith External Integration Test Workflow. Commit: 6c51567. PR: 18755. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18755&runId=3657731532_1

github-actions[bot] avatar Dec 09 '22 13:12 github-actions[bot]

/ok-to-test sha=97af6af

rahulramesha avatar Dec 12 '22 07:12 rahulramesha

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3673697995. Workflow: Appsmith External Integration Test Workflow. Commit: 97af6af. PR: 18755. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18755&runId=3673697995_1

github-actions[bot] avatar Dec 12 '22 07:12 github-actions[bot]

/ok-to-test sha=bd96663

rahulramesha avatar Dec 12 '22 10:12 rahulramesha

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3674698406. Workflow: Appsmith External Integration Test Workflow. Commit: bd96663. PR: 18755. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18755&runId=3674698406_1

github-actions[bot] avatar Dec 12 '22 10:12 github-actions[bot]

@rahulramesha @riodeuno I cannot see relevant properties coming in the content section. It is just displaying a replica of style in all the widgets Screen Shot 2022-12-12 at 4 36 45 PM

kamakshibhat-appsmith avatar Dec 12 '22 11:12 kamakshibhat-appsmith

/ok-to-test sha=08dc9b2

rahulramesha avatar Dec 12 '22 11:12 rahulramesha

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3675482700. Workflow: Appsmith External Integration Test Workflow. Commit: 08dc9b2. PR: 18755. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18755&runId=3675482700_1

github-actions[bot] avatar Dec 12 '22 11:12 github-actions[bot]

@kamakshibhat-appsmith This should be fixed now please check the latest dp once it is built

rahulramesha avatar Dec 12 '22 11:12 rahulramesha

/ok-to-test sha=1ec1fb0

rahulramesha avatar Dec 12 '22 17:12 rahulramesha

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3678220395. Workflow: Appsmith External Integration Test Workflow. Commit: 1ec1fb0. PR: 18755. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18755&runId=3678220395_1

github-actions[bot] avatar Dec 12 '22 17:12 github-actions[bot]

Checked on the DP, This has been working fine . Moving to Done

kamakshibhat-appsmith avatar Dec 14 '22 07:12 kamakshibhat-appsmith

/ok-to-test sha=f115b89

rahulramesha avatar Dec 14 '22 17:12 rahulramesha

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3697213568. Workflow: Appsmith External Integration Test Workflow. Commit: f115b89. PR: 18755. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18755&runId=3697213568_1

github-actions[bot] avatar Dec 14 '22 17:12 github-actions[bot]

/ok-to-test sha=9b57440

rahulramesha avatar Dec 15 '22 06:12 rahulramesha

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3701767343. Workflow: Appsmith External Integration Test Workflow. Commit: 9b57440. PR: 18755. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18755&runId=3701767343_1

github-actions[bot] avatar Dec 15 '22 06:12 github-actions[bot]

/ok-to-test sha=6c12579

rahulramesha avatar Dec 15 '22 09:12 rahulramesha

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3702900307. Workflow: Appsmith External Integration Test Workflow. Commit: 6c12579. PR: 18755. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18755&runId=3702900307_1

github-actions[bot] avatar Dec 15 '22 09:12 github-actions[bot]

/ok-to-test sha=ab1f0f5

rahulramesha avatar Dec 15 '22 16:12 rahulramesha

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3705921779. Workflow: Appsmith External Integration Test Workflow. Commit: ab1f0f5. PR: 18755. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18755&runId=3705921779_1

github-actions[bot] avatar Dec 15 '22 16:12 github-actions[bot]

/ok-to-test sha=0b1c6eb

rahulramesha avatar Dec 17 '22 12:12 rahulramesha

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3720044478. Workflow: Appsmith External Integration Test Workflow. Commit: 0b1c6eb. PR: 18755. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18755&runId=3720044478_1

github-actions[bot] avatar Dec 17 '22 12:12 github-actions[bot]